[template/angular] Prevent client-side dictionary API call when SSR data is available #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
@addy-pathania For the customers, please, add a note in Upgrade guide in order to let them know about this performance optimization
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
When SSR is executed, the data is pre-fetched and populated by Node.js server. However the DictionaryService API call is still executed in a browser on initial page load. We now transfer the pre-fetched SSR data to the client, preventing unnecessary client-side API calls and improving app's performance.
Testing Details
Types of changes