Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make template lint use node glob to ensure consistent lint results across OS #1959

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Make template lint use node glob to ensure consistent lint results across OS #1959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1db241a
Make template lint use node glob to ensure consistent lint results
Oct 24, 2024
d4f89b6
Updated changelong
Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Our versioning strategy is as follows:

### 🐛 Bug Fixes

* `[templates/nextjs]` `[templates/react-native]` `[templates/react]` Make lint use node glob for consistent linting across different OS ([#1959](https://github.com/Sitecore/jss/pull/1959))
* `[sitecore-jss-nextjs]` Link component prefetches files ([#1956](https://github.com/Sitecore/jss/pull/1956))
* `[templates/nextjs]` `[templates/react]` `[templates/angular]` `[templates/vue]` Fixed an issue when environment variable is undefined (not present in .env), that produced an "undefined" value in generated config file ([#1875](https://github.com/Sitecore/jss/pull/1875))
* `[templates/nextjs]` Fix embedded personalization not rendering correctly after navigation through router links. ([#1911](https://github.com/Sitecore/jss/pull/1911))
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
},
"scripts": {
"jss": "jss",
"lint": "eslint ./src/**/*.tsx ./src/**/*.ts ./scripts/**/*.ts",
"lint": "eslint \"./src/**/*.tsx\" \"./src/**/*.ts\" \"./scripts/**/*.ts\"",
"bootstrap": "ts-node --require dotenv-flow/config --project tsconfig.scripts.json scripts/bootstrap.ts && graphql-let",
"build": "cross-env NODE_ENV=production npm-run-all --serial bootstrap next:build",
"graphql:update": "ts-node --project tsconfig.scripts.json ./scripts/fetch-graphql-introspection-data.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"start-ios": "node ./build/start.js --platform ios",
"start-ios:connected": "scjss-verify-setup && node ./build/start.js --platform ios --appMode connected",
"start-ios:connected-tunnel": "scjss-verify-setup && node ./build/start.js --platform ios --appMode connected-tunnel",
"lint": "eslint ./src/**/*.js ./sitecore/definitions/**/*.js"
"lint": "eslint \"./src/**/*.js\" \"./sitecore/definitions/**/*.js\""
},
"dependencies": {
"@react-native-community/masked-view": "^0.1.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"bootstrap": "node scripts/bootstrap.js",
"graphql:update": "node -r @babel/register ./scripts/update-graphql-fragment-data.js",
"test": "react-scripts test --env=jsdom",
"lint": "eslint ./src/**/*.js ./sitecore/definitions/**/*.js ./scripts/**/*.js ./server/**/*.js ./data/**/*.yml",
"lint": "eslint \"./src/**/*.js\" \"./sitecore/definitions/**/*.js\" \"./scripts/**/*.js\" \"./server/**/*.js\" \"./data/**/*.yml\"",
"eject": "react-scripts eject",
"eject:script": "ncp ./scripts ./scripts-copy && node ./scripts-copy/eject.js && ncp ./scripts-copy ./scripts && del-cli ./scripts-copy",
"install-pre-push-hook": "node ./scripts/install-pre-push-hook.js"
Expand Down