[sitecore-jss-proxy][sitecore-jss-nextjs] Fix for getCSPHeader function #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorsk
requested review from
illiakovalenko and
art-alexeyenko
and removed request for
illiakovalenko
|
@yavorsk It seem analogues function from NextJs package should have the same problem: |
yavorsk
changed the title
yavorsk
changed the title
illiakovalenko
approved these changes
Nov 20, 2024
packages/sitecore-jss-proxy/src/middleware/editing/render.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-proxy/src/middleware/editing/render.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Illia Kovalenko <[email protected]>
Co-authored-by: Illia Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR fixes the getCSPHeader function so that it returns proper value for the CSP header when JSS_ALLOWED_ORIGINS lists multiple origins delimited with comma.
Testing Details
Types of changes