Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/angular] [templates/angular-sxp] [templates/angular-xmcloud] Updates for Angular XMC sample to work well with local containers and spa-starters monorepo in xmcloud-foundation #1983

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Nov 26, 2024

Description / Motivation

The updates in this PR are done to support local containers with angular spa sample as rendering host:

  • move style reference to bootstrap from angular base to angular-sxp template;
  • update tsconfig to make angular spa app work well with spa-starters monorepo and local containers in xmcloud-foundation;
  • use fs functions to delete and copy dist folder in proxy-build script;

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - smoke test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk changed the title [templates/angular] [templates/angular-sxp] [templates/angular-xmcloud] Supprt Angular XMC sample to work with local containers in xmcloud-foundation [templates/angular] [templates/angular-sxp] [templates/angular-xmcloud] Supprt Angular XMC sample to work well with local containers spa-starters monorepo in xmcloud-foundation Nov 26, 2024
@yavorsk yavorsk changed the title [templates/angular] [templates/angular-sxp] [templates/angular-xmcloud] Supprt Angular XMC sample to work well with local containers spa-starters monorepo in xmcloud-foundation [templates/angular] [templates/angular-sxp] [templates/angular-xmcloud] Updates for Angular XMC sample to work well with local containers and spa-starters monorepo in xmcloud-foundation Nov 26, 2024
@yavorsk yavorsk requested a review from a team November 26, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant