Use equals comparator when classes share a superclass #4516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the method responsible for finding a comparator to return the equals comparator if the two classes share an immediate superclass. One issue caused by the lack of these checks is the weird comparison stuff that goes on with potions such as:
Skript/src/main/java/ch/njol/skript/util/PotionEffectUtils.java
Lines 90 to 99 in e43c37e
However, I was wondering if it should compare if the classes share a common superclass at any point, not just the first level.
Target Minecraft Versions: Any
Requirements: None
Related Issues: #4183 (needs this PR)