Adds ability to listen to cancelled events #5896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleans up SkriptEventHandler#check() a bit more.
AyhamAl-Ali
added
the
enhancement
|
For another PR - Note this requires updating docs event pattern to add |
AyhamAl-Ali
added
the
require docs update
Closed
1 task
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0 to
3f08853
Compare
|
Closing in favour of #6207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to listen to events cancelled by other plugins by using
on all <event>.Previously, Skript would simply return before executing any triggers if the event was cancelled. Now it checks each trigger to see if each one is ignoring or listening to cancelled events via SkriptEvent#shouldIgnoreCancelled().
Also cleans up SkriptEventHandler#check() a bit more.
Edit: Converted to draft to await the merging of an event parsing rework by Tud (#5900). Current solutions have too much danger of polluting the event's tags or are very hacky.
Target Minecraft Versions:
Requirements:
Related Issues: #5891