Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entity damage event 1.20.4 constructor changes #6433

Closed
wants to merge 13 commits into from
Closed

Fix entity damage event 1.20.4 constructor changes #6433

wants to merge 13 commits into from

Conversation

TheLimeGlass
Copy link
Collaborator

Description

  • Fix entity damage event 1.20.4 constructor changes
  • Opens up proper support for DamageSource

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheLimeGlass TheLimeGlass mentioned this pull request Feb 14, 2024
Merged
@sovdeeth
Copy link
Member

I like it, but I don't think it's acceptable for a patch version due to the breaking change to ExprDamageCause. It'd be good for dev/feature for 2.9, though.

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Feb 14, 2024
@APickledWalrus APickledWalrus added the breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) label Feb 14, 2024
@TheLimeGlass TheLimeGlass mentioned this pull request Feb 14, 2024
Open
AyhamAl-Ali
AyhamAl-Ali requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

src/main/java/ch/njol/skript/expressions/ExprLastDamageCause.java Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLastDamageCause.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprLastDamageCause.java Show resolved Hide resolved
APickledWalrus
APickledWalrus requested changes May 6, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target dev/feature. No need for breaking changes in patch.

Also, I do not see any benefit from the changes made in HealthUtils. It should be okay as in (I'm assuming this is just from conflict resolution for the most part)

Base automatically changed from dev/patch to master June 1, 2024 19:39
@sovdeeth
Copy link
Member

Closing due to inactivity

@sovdeeth sovdeeth closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus requested changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@ShaneBeee ShaneBeee Awaiting requested review from ShaneBeee

@AyhamAl-Ali AyhamAl-Ali Awaiting requested review from AyhamAl-Ali

Assignees
No one assigned
Labels
breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheLimeGlass @sovdeeth @Moderocky @ShaneBeee @AyhamAl-Ali @APickledWalrus