Fix missing "and" warnings #7036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
Sep 4, 2024
sovdeeth
added
the
enhancement
APickledWalrus
requested changes
Sep 4, 2024
src/test/skript/tests/regressions/pull-6586-effhealth item mutation.sk
Outdated
Show resolved
Hide resolved
APickledWalrus
approved these changes
Sep 4, 2024
|
Oh this could probably target patch if you want to rebase it |
|
Seems it didn't like changing the base, I can rebase this for you if you need. |
Moderocky
force-pushed
the
fix-test-and-warns
branch
from
8934bd3 to
218d749
Compare
|
I think I fixed it for you please double check it looks right though! |
Moderocky
approved these changes
Sep 4, 2024
|
SecFilter and ExprJoinSplit are not up to date, do I have to redo them |
Don't worry I removed them (they were feature-only tests) it should be all fine now. |
Moderocky
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes missing
andwarnings in a few tests. This reduces the amount warnings that show up, increasing the chances of contributors finding warnings in their own PRs, and making it easier to find errors.Target Minecraft Versions: any
Requirements: none
Related Issues: none