Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 1.21.3 test support #7135

Closed
wants to merge 16 commits into from
Closed

Adds 1.21.3 test support #7135

wants to merge 16 commits into from

Conversation

EquipableMC
Copy link
Contributor

@EquipableMC EquipableMC commented Oct 6, 2024 •
edited
Loading

Description

This simply adds support for 1.21.3 in tests, and also fixes a known issue with EffHealth.sk test where you cannot resurrect a dead mob

Target Minecraft Versions: 1.21.1
Requirements: none
Related Issues: none

@EquipableMC
Adds 1.21.1 test support
ef06597 
also fixes health test
@Efnilite Efnilite added enhancement Feature request, an issue about something that could be improved, or a PR improving something. unit testing For issues/PRs related to the Skript unit testing system. labels Oct 7, 2024
TheLimeGlass
TheLimeGlass requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@TheLimeGlass TheLimeGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update the gradle.properties

-testEnv=java21/paper-1.21.0
+testEnv=java21/paper-1.21.1

@EquipableMC
Copy link
Contributor Author

You forgot to update the gradle.properties

-testEnv=java21/paper-1.21.0

+testEnv=java21/paper-1.21.1

Ah oops, will do when I can!

APickledWalrus
APickledWalrus requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just replace the existing 1.21.0 environment

@EquipableMC EquipableMC changed the title Adds 1.21.1 test support Adds 1.21.3 test support Oct 26, 2024
@EquipableMC
Copy link
Contributor Author

EquipableMC commented Oct 26, 2024 •
edited
Loading

Updated this PR to instead add support for 1.21.3
Edit: I will be doing tests before I push any changes

sovdeeth
sovdeeth requested changes Oct 26, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@EquipableMC EquipableMC marked this pull request as draft October 27, 2024 12:12
@EquipableMC EquipableMC marked this pull request as ready for review October 31, 2024 20:09
@EquipableMC
Copy link
Contributor Author

EquipableMC commented Oct 31, 2024 •
edited
Loading

Closing this PR in favor for #7173.

@EquipableMC EquipableMC deleted the 1.21.1-tests-support branch October 31, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth requested changes

@Efnilite Efnilite Efnilite approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. unit testing For issues/PRs related to the Skript unit testing system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EquipableMC @sovdeeth @TheLimeGlass @APickledWalrus @Efnilite