Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility class for easier building of toString #7168

Merged
merged 17 commits into from
Nov 11, 2024

Conversation

Efnilite
Copy link
Member

Description

Adds a class for constructing a toString which is a lot more readable than the current usual combination of ternaries and string concatenation. Also includes some examples :)


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 29, 2024
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems alright

src/main/java/ch/njol/skript/lang/SyntaxStringBuilder.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
@Efnilite Efnilite requested a review from sovdeeth October 30, 2024 00:17
@Efnilite Efnilite requested a review from Pikachu920 October 30, 2024 14:57
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 8, 2024
@sovdeeth sovdeeth merged commit ae710ba into SkriptLang:dev/feature Nov 11, 2024
5 checks passed
@Efnilite Efnilite deleted the improve-toString branch November 12, 2024 22:01
@Efnilite Efnilite mentioned this pull request Nov 13, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants