Fix linebreaks when importing strings #813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #812. When exporting strings to a CSV, actual linebreaks are swapped for
\n
, as shown here:The issue arises from the fact that this is not undone when importing, meaning the linebreaks stay as
\n
instead of actual linebreaks. This can be undone by adding areplace("\\n", "\n")
to the code relevant to importing, causing the new code to look like this:This should cause linebreaks to be imported properly instead of as
\n
.I'm unable to build SkyTemple to see if this works myself, but I'm hoping my logic makes sense.