Skip to content

Commit

Permalink
Reuse proxy location when set (#1394)
Browse files Browse the repository at this point in the history
  • Loading branch information
wintonzheng authored Dec 16, 2024
1 parent e2f886d commit 1b7ff69
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
4 changes: 4 additions & 0 deletions skyvern-frontend/src/routes/workflows/WorkflowRun.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { statusIsFinalized, statusIsRunningOrQueued } from "../tasks/types";
import { useWorkflowQuery } from "./hooks/useWorkflowQuery";
import { useWorkflowRunQuery } from "./hooks/useWorkflowRunQuery";
import { cn } from "@/util/utils";
import { ProxyLocation } from "@/api/types";

function WorkflowRun() {
const { workflowRunId, workflowPermanentId } = useParams();
Expand Down Expand Up @@ -79,6 +80,8 @@ function WorkflowRun() {
const workflowRunIsFinalized = workflowRun && statusIsFinalized(workflowRun);

const parameters = workflowRun?.parameters ?? {};
const proxyLocation =
workflowRun?.proxy_location ?? ProxyLocation.Residential;

const title = workflowIsLoading ? (
<Skeleton className="h-9 w-48" />
Expand Down Expand Up @@ -189,6 +192,7 @@ function WorkflowRun() {
to={`/workflows/${workflowPermanentId}/run`}
state={{
data: parameters,
proxyLocation,
}}
>
<PlayIcon className="mr-2 h-4 w-4" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ function WorkflowRunParameters() {
(parameter) => parameter.parameter_type === "workflow",
);

const proxyLocation = location.state
? (location.state.proxyLocation as ProxyLocation)
: null;

const initialValues = location.state?.data
? location.state.data
: workflowParameters?.reduce(
Expand Down Expand Up @@ -95,7 +99,10 @@ function WorkflowRunParameters() {
initialValues={initialValues}
workflowParameters={workflowParameters}
initialSettings={{
proxyLocation: workflow.proxy_location ?? ProxyLocation.Residential,
proxyLocation:
proxyLocation ??
workflow.proxy_location ??
ProxyLocation.Residential,
webhookCallbackUrl: workflow.webhook_callback_url ?? "",
}}
/>
Expand Down

0 comments on commit 1b7ff69

Please sign in to comment.