ObserverThought reproduce migration script #1338
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2d726bf in 31 seconds
More details
- Looked at
97lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_U4C7Zwo7CiYTCyZL
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -73,31 +78,19 @@ def upgrade() -> None: | |||
| op.add_column("artifacts", sa.Column("workflow_run_block_id", sa.String(), nullable=True)) | |||
| op.add_column("artifacts", sa.Column("observer_cruise_id", sa.String(), nullable=True)) | |||
| op.create_index("org_workflow_run_index", "artifacts", ["organization_id", "workflow_run_id"], unique=False) | |||
| op.create_foreign_key(None, "artifacts", "observer_cruises", ["observer_cruise_id"], ["observer_cruise_id"]) | |||
There was a problem hiding this comment.
Using None for foreign key constraint names can make it difficult to identify constraints later. Consider providing explicit names for these constraints.
wintonzheng
force-pushed
the
shu/add_workflow_run_block_id_to_observer_thought
branch
from
2d726bf to
94aebe6
Compare
wintonzheng
deleted the
shu/add_workflow_run_block_id_to_observer_thought
branch
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 94aebe6 in 26 seconds
More details
- Looked at
58lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_ggCCGhLsTB6Ylo6g
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Add
ObserverCruiseandObserverThoughtentities with new columns and foreign keys to support enhanced artifact tracking.workflow_run_block_idandobserver_cruise_idcolumns toartifactstable in Alembic migration script.observer_cruisesandobserver_thoughtstables with relevant foreign key constraints in Alembic migration script.artifactstable to reference new tables.workflow_run_block_idtoObserverThoughtclass inmodels.py.ObserverCruiseandObserverThoughtclasses inmodels.pywith appropriate fields and foreign keys.This description was created by
for 94aebe6. It will automatically update as commits are pushed.