Resolve prolems with saved task

[wintonzheng]

Important

Improves JSON handling in task forms by introducing safeParseMaybeJSONString and removing redundant parsing logic in CreateNewTaskFormPage.tsx and SavedTaskForm.tsx.

• Behavior:
  • In CreateNewTaskFormPage.tsx, navigationPayload is checked if it's a string before JSON stringifying.
  • In SavedTaskForm.tsx, safeParseMaybeJSONString is used to parse extractedInformationSchema and errorCodeMapping.
• Functions:
  • Introduced safeParseMaybeJSONString in SavedTaskForm.tsx to safely parse JSON strings.
• Misc:
  • Removed redundant JSON parsing logic in createTaskRequestObject and createTaskTemplateRequestObject in SavedTaskForm.tsx.

^{This description was created by for 4fb934a. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on 4fb934a in 21 seconds

More details

• Looked at 121 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:63

• Draft comment:
  The safeParseMaybeJSONString function returns the original payload if parsing fails. Consider logging a warning or handling the error differently if a valid JSON object is expected.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The safeParseMaybeJSONString function is used to parse JSON strings safely. However, it returns the original payload if parsing fails, which might not be the desired behavior if the payload is expected to be a valid JSON string. This could lead to unexpected behavior if the function is used in contexts where a valid JSON object is required.

2. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:87

• Draft comment:
  Ensure that safeParseMaybeJSONString is used consistently and that its behavior aligns with the expectations of the code using it. This applies to its usage in createTaskRequestObject and createTaskTemplateRequestObject.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The safeParseMaybeJSONString function is used multiple times in the codebase. It is important to ensure that the function's behavior is consistent with the expectations of the code that uses it.

Workflow ID: wflow_6DK59BAuhcq0sqzt

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4fb934a in 1 minute and 17 seconds

More details

• Looked at 121 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:63

• Draft comment:
  Consider adding a check to ensure payload is a string before attempting to parse it. This will prevent unexpected behavior if non-string inputs are passed.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function safeParseMaybeJSONString is used to parse JSON strings safely. However, the function does not handle cases where the input is not a string, which could lead to unexpected behavior if non-string inputs are passed. This function should be updated to handle such cases more gracefully.

2. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:55

• Draft comment:
  The safeParseMaybeJSONString function is used here. Ensure it handles non-string inputs gracefully to prevent unexpected behavior. This applies to other instances where this function is used.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The safeParseMaybeJSONString function is used multiple times in the codebase, including in createTaskRequestObject and createTaskTemplateRequestObject. The suggestion to handle non-string inputs applies to all these instances.

3. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:87

• Draft comment:
  The safeParseMaybeJSONString function is used here. Ensure it handles non-string inputs gracefully to prevent unexpected behavior. This applies to other instances where this function is used.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The safeParseMaybeJSONString function is used multiple times in the codebase, including in createTaskRequestObject and createTaskTemplateRequestObject. The suggestion to handle non-string inputs applies to all these instances.

Workflow ID: wflow_WGWadUfMcPwwdFNL

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.