fix issues in forms page, add prompt editing

[wintonzheng]

Important

Enhance FormsPage.tsx with prompt editing and layout fixes, refine tab management in WorkflowBlockCollapsibleContent.tsx, and clean up database models.

• FormsPage.tsx:
  • Added navigationGoal to contactFormTaskSchema with default values.
  • Introduced showAdvancedContent state for toggling advanced settings.
  • Removed ScrollArea and ScrollAreaViewport for layout simplification.
  • Added prompt editing functionality with a toggle button.
• WorkflowBlockCollapsibleContent.tsx:
  • Changed activeTab state to use string literals for clarity.
  • Added statusIsFinalized check for conditional tab rendering.
  • Improved tab navigation logic for task status handling.
• Database Models:
  • Removed observer_thought_id from ArtifactModel.
  • Removed user_input and observation from ObserverThought.

^{This description was created by for ecbcd0f. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to b2a3a96 in 13 seconds

More details

• Looked at 137 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/db/models.py:172

• Draft comment:
  The observer_thought_id column is removed from ArtifactModel but still exists in ObserverThought. Ensure this removal is intentional and won't cause inconsistencies.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_q26UHBSOhTDPlXUf

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on b2a3a96 in 20 seconds

More details

• Looked at 116 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/WorkflowBlockCollapsibleContent.tsx:24

• Draft comment:
  Consider using a ternary operator for the initial state assignment of activeTab to make it more explicit:

const [activeTab, setActiveTab] = useState<"output" | "goal" | "parameters">(
  task.status === Status.Completed ? "output" : "goal"
);

• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of string literals for the activeTab state is a good improvement for clarity. However, the initial value assignment could be more explicit.

2. skyvern-frontend/src/routes/workflows/WorkflowBlockCollapsibleContent.tsx:126

• Draft comment:
  Consider storing the result of statusIsFinalized(task) in a variable to avoid repeated function calls and improve readability.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The statusIsFinalized function is used multiple times to check the task status. It might be beneficial to store its result in a variable for reuse, improving readability and performance slightly.

Workflow ID: wflow_PY3VVPHQMFEgwrI2

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on ecbcd0f in 20 seconds

More details

• Looked at 20 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern/forge/sdk/db/models.py:172

• Draft comment:
  The PR description states that observer_thought_id should be removed from ArtifactModel, but it is still present. Please ensure the code matches the PR description.
• Reason this comment was not posted:
  Comment did not seem useful.

2. skyvern/forge/sdk/db/models.py:528

• Draft comment:
  The PR description states that user_input and observation should be removed from ObserverThought, but they are still present. Please ensure the code matches the PR description.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_oBT3efAjmoe2ax1b

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.