migrate Organization data model from skyvern/forge/sdk/models.py to skyvern/forge/sdk/schemas/organizations.py #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Migrate `Organization` model from `models.py` to `schemas/organizations.py` and update imports accordingly. > > - **Imports**: > - Update import paths for `Organization` from `skyvern/forge/sdk/models` to `skyvern/forge/sdk/schemas/organizations` in `agent_functions.py`, `app.py`, and `cloud_permission_checker.py`. > - Similar updates in `db_client.py`, `checkout.py`, and `observer.py`. > - **Models**: > - Remove `Organization` and `OrganizationAuthToken` classes from `models.py`. > - Add `Organization` and `OrganizationAuthToken` classes to `schemas/organizations.py`. > - **Misc**: > - Adjust related imports in `agent.py`, `agent_functions.py`, and `org_auth_service.py`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for ea501c5324f88a81c7abf3a1ea5f44ae8d821fa9. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cc68b2c in 28 seconds
More details
- Looked at
253lines of code in13files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/org_auth_service.py:16
- Draft comment:
Organize imports according to PEP 8 guidelines. Group standard library imports, third-party imports, and local imports separately with a blank line between each group. This applies to other files as well. - Reason this comment was not posted:
Confidence changes required:33%
The migration of the Organization model from models.py to schemas/organizations.py seems to be done correctly. However, there is a minor issue with the import statements in some files. The import statements should be organized according to PEP 8 guidelines, which suggest grouping imports into standard library imports, related third-party imports, and local application/library-specific imports, with a blank line between each group.
Workflow ID: wflow_7UFekTWQSoE2FusX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to cc68b2c in 45 seconds
More details
- Looked at
253lines of code in13files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/org_auth_service.py:16
- Draft comment:
from skyvern.forge.sdk.db.enums import OrganizationAuthTokenType
- Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment suggests an import path that is not supported by the diff. The diff shows OrganizationAuthTokenType being imported from schemas, not db.enums. There is no evidence in the diff that supports the suggested change to db.enums.
I might be missing some context about where OrganizationAuthTokenType is defined, but based on the diff, it seems to be correctly imported from schemas.
The diff provides clear evidence that the import path was changed to schemas, and there is no indication that db.enums is the correct path.
Delete the comment as it suggests an incorrect import path change that is not supported by the diff.
Workflow ID: wflow_96GtKQSHVh7rRtJV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 34734d6 in 22 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_2PeXjCb434d0cDUS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Migrate
Organizationmodel frommodels.pytoschemas/organizations.pyand update imports accordingly.OrganizationandOrganizationAuthTokenclasses frommodels.py.OrganizationandOrganizationAuthTokenclasses toschemas/organizations.py.Organizationfrommodelstoschemas/organizationsinagent_functions.py,app.py, andcloud_permission_checker.py.db_client.py,checkout.py, andobserver.py.agent.py,agent_functions.py, andorg_auth_service.py.This description was created by
for 34734d6. It will automatically update as commits are pushed.