Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing video recording - recording is stored in the first step #1350

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 7, 2024

Important

Fixes video recording storage by retrieving the recording artifact from the first step in build_task_response() and adds get_first_step() to client.py.

  • Behavior:
    • Fixes video recording storage by retrieving the recording artifact using the first step in build_task_response() in agent.py.
  • Database:
    • Adds get_first_step() to client.py to fetch the first step of a task for recording retrieval.
  • Misc:
    • Minor logging changes in client.py for error handling.

This description was created by Ellipsis for c263b98. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 457cf51 in 36 seconds

More details
  • Looked at 69 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:1640
  • Draft comment:
    The step_id used for fetching the recording artifact should be first_step.step_id instead of last_step.step_id to align with the intent of using the first step for recording.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_HbTwbqFQYoEI3YDD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on b041410 in 13 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:1639
  • Draft comment:
    The change from last_step.step_id to first_step.step_id is correct for retrieving the recording artifact from the first step, as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR is correct as it updates the step_id from last_step to first_step for retrieving the recording artifact. This aligns with the intent to fix video recording storage by using the first step for artifact retrieval.

Workflow ID: wflow_2YfevTKFGe9g15rf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng force-pushed the shu/fix_video_recording_missing branch from b041410 to c263b98 Compare December 7, 2024 20:20
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on c263b98 in 18 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/db/client.py:340
  • Draft comment:
    The log message should indicate that the first step was not found, not the latest step.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The log message in the get_first_step method is misleading. It should indicate that the first step was not found, not the latest step.

Workflow ID: wflow_zZXTCgjzOyho2Zes


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit fbc6677 into main Dec 8, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/fix_video_recording_missing branch December 8, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant