Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend custom selection to date #1357

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Dec 9, 2024

Important

Extend custom selection to handle dates by updating templates and handlers.

  • Behavior:
    • Adds current UTC datetime in YYYY-MM-DD HH:MM format to custom-select.j2.
    • Updates opened-dropdown-confirm.j2 to consider calendar views or date pickers as open dropdown menus.
  • Handlers:
    • Modifies select_from_dropdown() in handler.py to include utc_datetime in the payload.

This description was created by Ellipsis for 62a4249. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 62a4249 in 13 seconds

More details
  • Looked at 42 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/custom-select.j2:54
  • Draft comment:
    Ensure utc_datetime is used consistently across the codebase. Consider adding tests to verify its format and usage.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a new variable utc_datetime to the template context, which is formatted as a string. This is a good addition for logging or tracking purposes, but it should be consistent with the rest of the codebase.

Workflow ID: wflow_NjI8Twhcq3Cxrqhq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 20f30d1 into main Dec 9, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/extend-custom-selection-to-date branch December 9, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant