Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize auto completion trigger #1359

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Dec 9, 2024

Important

Optimize auto-completion by making potential values count configurable and updating related logic.

  • Behavior:
    • Configurable potential values count for auto-completion added as AUTO_COMPLETION_POTENTIAL_VALUES_COUNT in constants.py.
    • Updated auto-completion-potential-answers.j2 to use {{ potential_value_count }} for dynamic potential values count.
    • Modified input_or_auto_complete_input() in handler.py to use AUTO_COMPLETION_POTENTIAL_VALUES_COUNT.
  • Misc:
    • Clarified docstring in parse-input-or-select-context.j2 to include postal code as non-location input.

This description was created by Ellipsis for 7df4c88. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7df4c88 in 1 minute and 34 seconds

More details
  • Looked at 78 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:1604
  • Draft comment:
    The log message mentions '10 potential values', but the constant AUTO_COMPLETION_POTENTIAL_VALUES_COUNT is set to 5. Consider updating the log message to reflect the correct number of potential values.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_m0GjuMJUq4cOPPGE


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 4a42276 into main Dec 9, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/optimize-auto-completion-trigger branch December 9, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant