render complete criterion in task block #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `completeCriterion` and `terminateCriterion` fields to `TaskNode` for enhanced task completion criteria handling. > > - **Behavior**: > - Add `completeCriterion` and `terminateCriterion` fields to `TaskNode` in `TaskNode.tsx`. > - Render `completeCriterion` input in `TaskNode` UI. > - **Data Handling**: > - Update `TaskNodeData` type in `types.ts` to include `completeCriterion` and `terminateCriterion`. > - Modify `convertToNode()` and `getWorkflowBlock()` in `workflowEditorUtils.ts` to handle new fields. > - **YAML Conversion**: > - Update `TaskBlockYAML` type in `workflowYamlTypes.ts` to include `completeCriterion` and `terminateCriterion`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c2e67dce21e523632dd4fc381e5e01ad4999cc88. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 88ed706 in 28 seconds
More details
- Looked at
154lines of code in7files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:225
- Draft comment:
TheterminateCriterionfield is added to theTaskNodedata but is not rendered in the UI. Consider adding a UI element forterminateCriterionsimilar tocompleteCriterion. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_OspaNs47prk7xNN5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 88ed706 in 38 seconds
More details
- Looked at
154lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Boa02hKJVtMJ0JAt
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -51,6 +51,8 @@ function TaskNode({ id, data }: NodeProps<TaskNode>) { | |||
| url: data.url, | |||
| navigationGoal: data.navigationGoal, | |||
| dataExtractionGoal: data.dataExtractionGoal, | |||
There was a problem hiding this comment.
terminateCriterion is added to the TaskNode data but not rendered in the UI. Consider adding a UI element for it.
msalihaltun
deleted the
salih/render-complete-criterion-in-task-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
completeCriterionandterminateCriterionfields toTaskNodefor enhanced task completion criteria handling.completeCriterionandterminateCriterionfields toTaskNodeinTaskNode.tsx.completeCriterioninput inTaskNodeUI.TaskNodeDatatype intypes.tsto includecompleteCriterionandterminateCriterion.convertToNode()andgetWorkflowBlock()inworkflowEditorUtils.tsto handle new fields.TaskBlockYAMLtype inworkflowYamlTypes.tsto includecompleteCriterionandterminateCriterion.This description was created by
for 88ed706. It will automatically update as commits are pushed.