add completion criteria to navigation block as well #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add completion and termination criteria to `NavigationNode` and `LoginNode`, updating types and utility functions. > > - **Behavior**: > - Add `completeCriterion` and `terminateCriterion` to `NavigationNode` and `LoginNode` in `NavigationNode.tsx` and `LoginNode.tsx`. > - Update `convertToNode()` and `getWorkflowBlock()` in `workflowEditorUtils.ts` to handle new criteria. > - **Types**: > - Add `completeCriterion` and `terminateCriterion` to `NavigationNodeData` and `LoginNodeData` in `types.ts`. > - Update `NavigationBlock`, `LoginBlock`, `NavigationBlockYAML`, and `LoginBlockYAML` in `workflowTypes.ts` and `workflowYamlTypes.ts` to include new criteria. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for a267b3843943cb666f0a14748ec2d03c0e0b4077. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a1617e6 in 30 seconds
More details
- Looked at
220lines of code in7files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:922
- Draft comment:
Consider adding validation forcompleteCriterionandterminateCriterioningetWorkflowErrorsforNavigationNodeandLoginNodeto ensure at least one is provided. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_nRKxjB2SmU0gNY8t
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on a1617e6 in 53 seconds
More details
- Looked at
220lines of code in7files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/NavigationNode/NavigationNode.tsx:144
- Draft comment:
terminateCriterionis added to the state but not used in the UI. Consider adding a UI component for it, similar tocompleteCriterion. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_5rClEatydx2jSg9H
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -41,6 +41,8 @@ function LoginNode({ id, data }: NodeProps<LoginNode>) { | |||
| cacheActions: data.cacheActions, | |||
| totpVerificationUrl: data.totpVerificationUrl, | |||
| totpIdentifier: data.totpIdentifier, | |||
| completeCriterion: data.completeCriterion, | |||
| terminateCriterion: data.terminateCriterion, | |||
| }); | |||
| const deleteNodeCallback = useDeleteNodeCallback(); | |||
There was a problem hiding this comment.
terminateCriterion is added to the state but not used in the UI. Consider adding a UI component for it, similar to completeCriterion.
msalihaltun
deleted the
salih/complete-criterion-on-task-based-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add completion and termination criteria to
NavigationNodeandLoginNode, updating types and utility functions.completeCriterionandterminateCriteriontoNavigationNodeandLoginNodeinNavigationNode.tsxandLoginNode.tsx.convertToNode()andgetWorkflowBlock()inworkflowEditorUtils.tsto handle new criteria.completeCriterionandterminateCriteriontoNavigationNodeDataandLoginNodeDataintypes.ts.NavigationBlock,LoginBlock,NavigationBlockYAML, andLoginBlockYAMLinworkflowTypes.tsandworkflowYamlTypes.tsto include new criteria.This description was created by
for a1617e6. It will automatically update as commits are pushed.