Improve workflow failure reason #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Improves failure reason messages in `setup_workflow_run` in `service.py` by including exception details. > > - **Behavior**: > - Enhanced failure reason messages in `setup_workflow_run` in `service.py` to include exception details. > - Specifically, appends exception message to generic failure reason and `SkyvernException` specific message. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for d01f0f1bd7d0a1927c4a6793472ea5d4cf07cc33. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c57c3d3 in 9 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:177
- Draft comment:
Consider changing 'an SkyvernException' to 'a SkyvernException' for grammatical correctness.
failure_reason = f"Setup workflow failed due to a SkyvernException({e.__class__.__name__}): {str(e)}"
- Reason this comment was not posted:
Confidence changes required:10%
The PR aims to improve failure reason messages by including exception details. The changes are correctly implemented, but there is a minor grammatical error in the message format.
Workflow ID: wflow_UBKDKWoOZLjLfWV3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c57c3d3 in 9 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:177
- Draft comment:
Consider changing 'an SkyvernException' to 'a SkyvernException' for grammatical correctness.
failure_reason = f"Setup workflow failed due to a SkyvernException({e.__class__.__name__}): {str(e)}"
- Reason this comment was not posted:
Confidence changes required:10%
The PR aims to improve the failure reason messages by including exception details. The changes are straightforward and align with the intent described in the PR. However, there is a minor grammatical error in the failure message for SkyvernException.
Workflow ID: wflow_Oc4GMZjtsaRNqB8X
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
@LawyZheng for review |
LawyZheng
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance failure reason messages in
setup_workflow_runinservice.pyto include exception details.setup_workflow_runinservice.pyto include exception details.SkyvernExceptionspecific message.This description was created by
for c57c3d3. It will automatically update as commits are pushed.