Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback to input when input selection failed #1393

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Dec 16, 2024

Important

Adds fallback to input text when input selection fails, with new exception handling and logging in handler.py.

  • Behavior:
    • Adds fallback to input text when input selection fails in handle_input_text_action() in handler.py.
    • Logs specific error when custom selection returns an error and continues with input text.
  • Exceptions:
    • Adds InteractWithDropdownContainer exception in exceptions.py for handling dropdown container interaction errors.
  • Logging:
    • Adds logging for custom selection errors and fallback actions in handle_input_text_action() in handler.py.

This description was created by Ellipsis for 93fea3f. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 93fea3f in 25 seconds

More details
  • Looked at 77 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:1969
  • Draft comment:
    The InteractWithDropdownContainer exception is added but not used in the handle_input_text_action function. Consider handling this exception in handle_input_text_action for consistency.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_LaHJ3iQiiNhJGXxf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit e2f886d into main Dec 16, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fallback-to-input-when-input-selection-failed branch December 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant