gracefully handle NONE computedstyle

[LawyZheng]

Important

Replace window.getComputedStyle with getElementComputedStyle in domUtils.js to handle null returns gracefully, improving robustness.

• Behavior:
  • Replace window.getComputedStyle with getElementComputedStyle in domUtils.js to handle null returns gracefully.
  • Add null checks for computed styles in isScrollableOverflow(), checkRequiredFromStyle(), getElementContext(), and other functions.
• Functions:
  • Modify isInteractable() to use getElementComputedStyle() for cursor checks.
  • Update isWindowScrollable() to use getElementComputedStyle() for overflow checks.
  • Adjust expectHitTarget() to handle display: contents elements correctly.
• Misc:
  • Add null checks in loops and conditions to prevent errors when computed styles are null.

^{This description was created by for 1513292. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 1513292 in 16 seconds

More details

• Looked at 176 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/webeye/scraper/domUtils.js:106

• Draft comment:
  Ensure consistent handling of null or undefined computed styles. Consider using optional chaining (?.) consistently across the codebase to access properties of computed styles, as seen in line 109 and elsewhere.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a new function getElementComputedStyle to handle cases where window.getComputedStyle might return null. This function is used throughout the code to ensure that the computed style is safely accessed. However, there are some places where the code checks for null or undefined computed styles, and these checks are not consistent. For instance, in some places, the code uses optional chaining (?.) to access properties of the computed style, while in others, it explicitly checks if the computed style is null or undefined. This inconsistency can lead to confusion and potential bugs if not handled properly.

Workflow ID: wflow_tp9iDvKcBnlVhxI5

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.