Revert "Add ability to use observer in the prompt section (#3194)" #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' This reverts commit a43c00f520d281184685bae8a99cd6268ef8a5a1. <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Reverts observer feature in the prompt section by removing related types, components, and logic. > > - **Revert Observer Feature**: > - Remove `ObserverCruise` type from `types.ts`. > - Remove `CustomSelectItem` and `SelectItemText` components from `select.tsx`. > - Remove observer-related logic and UI elements from `PromptBox.tsx`. > - Remove `observerFeatureEnabled` export from `env.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for e78c60d36ea1b2147c6e8075fe5d176b911f91b7. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6a70663 in 18 seconds
More details
- Looked at
233lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. skyvern-frontend/src/components/ui/select.tsx:159
- Draft comment:
The removal ofCustomSelectItemandSelectItemTextcomponents is consistent with the PR's intent to revert the observer feature. - Reason this comment was not posted:
Confidence changes required:10%
The PR removesCustomSelectItemandSelectItemTextcomponents fromselect.tsx, which aligns with the intent to revert the observer feature.
2. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:184
- Draft comment:
The removal of observer-related logic is consistent with the PR's intent to revert the observer feature. - Reason this comment was not posted:
Confidence changes required:10%
The PR removes observer-related logic fromPromptBox.tsx, which is consistent with the intent to revert the observer feature.
3. skyvern-frontend/src/util/env.ts:22
- Draft comment:
The removal ofobserverFeatureEnabledexport is consistent with the PR's intent to revert the observer feature. - Reason this comment was not posted:
Confidence changes required:10%
The PR removes theobserverFeatureEnabledexport fromenv.ts, which aligns with the intent to revert the observer feature.
Workflow ID: wflow_ahehvIrt2WZe5gu9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a43c00f520d281184685bae8a99cd6268ef8a5a1.
Important
Reverts observer feature in the prompt section by removing related types, components, and logic.
ObserverCruisetype fromtypes.ts.CustomSelectItemandSelectItemTextcomponents fromselect.tsx.PromptBox.tsx.observerFeatureEnabledexport fromenv.ts.This description was created by
for 6a70663. It will automatically update as commits are pushed.