change the name of observer in dropdown #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Rename dropdown items in `PromptBox.tsx` to `Skyvern 2.0 (Observer)` and `Skyvern 1.0 (Tasks)`. > > - **UI Change**: > - In `PromptBox.tsx`, rename dropdown item from `Observer` to `Skyvern 2.0 (Observer)` for `CustomSelectItem` with value `v2`. > - Rename dropdown item from `Task` to `Skyvern 1.0 (Tasks)` for `CustomSelectItem` with value `v1`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 02fe03a005aa95a80d60dcbf3d380e8607df7690. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Rename dropdown items in `PromptBox.tsx` to `Skyvern 2.0 (Observer)` and `Skyvern 1.0 (Tasks)`. > > - **UI Change**: > - In `PromptBox.tsx`, rename dropdown item from `Observer` to `Skyvern 2.0 (Observer)` for `CustomSelectItem` with value `v2`. > - Rename dropdown item from `Task` to `Skyvern 1.0 (Tasks)` for `CustomSelectItem` with value `v1`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 02fe03a005aa95a80d60dcbf3d380e8607df7690. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 8210d45 in 12 seconds
More details
- Looked at
30lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:240
- Draft comment:
The width ofSelectTriggerwas changed fromw-32tow-48. This change is not mentioned in the PR description. Ensure this change is intentional and necessary. - Reason this comment was not posted:
Confidence changes required:50%
The PR description specifies changing the dropdown item names, which has been done correctly. However, the width of the SelectTrigger was also changed from 'w-32' to 'w-48'. This change is not mentioned in the PR description and should be justified or reverted.
Workflow ID: wflow_zJPeytiD9XILhazH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 8210d45 in 11 seconds
More details
- Looked at
84lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:240
- Draft comment:
The width ofSelectTriggerhas been changed fromw-32tow-48. Ensure this change is intentional and does not negatively impact the UI layout. - Reason this comment was not posted:
Confidence changes required:50%
The PR description indicates a change in the dropdown item names inPromptBox.tsx. The changes in the code reflect this requirement correctly. However, the change in the width of theSelectTriggerfromw-32tow-48should be noted as it affects the UI layout.
Workflow ID: wflow_d0fOVyU4VCHqg5AU
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 389446c in 26 seconds
More details
- Looked at
53lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern/forge/sdk/db/id.py:157
- Draft comment:
generate_persistent_browser_session_idshould be removed as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
2. skyvern/forge/sdk/db/models.py:546
- Draft comment:
PersistentBrowserSessionModelshould be removed as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_nV2ZBCmY0fpiLWpM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Rename dropdown items in
PromptBox.tsxand removePersistentBrowserSessionModeland related ID generation.PromptBox.tsx, rename dropdown item fromObservertoSkyvern 2.0 (Observer)forCustomSelectItemwith valuev2.TasktoSkyvern 1.0 (Tasks)forCustomSelectItemwith valuev1.PersistentBrowserSessionModelfrommodels.py.generate_persistent_browser_session_id()fromid.py.This description was created by
for 389446c. It will automatically update as commits are pushed.