Change default option for observer #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Change default selection in `PromptBox` to `v1` and update UI descriptions for task options. > > - **Behavior**: > - Change default `selectValue` in `PromptBox` from `observerFeatureEnabled ? "v2" : "v1"` to always `"v1"`. > - Swap positions and descriptions of `CustomSelectItem` for `v1` and `v2` in `PromptBox`. > - **UI**: > - `Skyvern 1.0 (Tasks)` is now the default and described as "best for simple tasks". > - `Skyvern 2.0 (Observer)` is now secondary and described as "best for complex tasks". > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 347154ed7e8811ef64e305b6071327c8d8edc351. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Change default selection in `PromptBox` to `v1` and update UI descriptions for task options. > > - **Behavior**: > - Change default `selectValue` in `PromptBox` from `observerFeatureEnabled ? "v2" : "v1"` to always `"v1"`. > - Swap positions and descriptions of `CustomSelectItem` for `v1` and `v2` in `PromptBox`. > - **UI**: > - `Skyvern 1.0 (Tasks)` is now the default and described as "best for simple tasks". > - `Skyvern 2.0 (Observer)` is now secondary and described as "best for complex tasks". > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 347154ed7e8811ef64e305b6071327c8d8edc351. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 25ca4b9 in 16 seconds
More details
- Looked at
45lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:239
- Draft comment:
Consider removing theobserverFeatureEnabledcheck around theSelectcomponent since the default behavior has changed to always use "v1". This check might be redundant now. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_xKgYIjPIuLkUi5BV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 25ca4b9 in 24 seconds
More details
- Looked at
99lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern/forge/sdk/db/id.py:153
- Draft comment:
Ensure thatgenerate_persistent_browser_session_idis not used elsewhere in the codebase before removing it. - Reason this comment was not posted:
Comment did not seem useful.
2. skyvern/forge/sdk/db/models.py:540
- Draft comment:
Ensure thatPersistentBrowserSessionModelis not used elsewhere in the codebase before removing it. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_7Ayp25ikkvpFt31o
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0599892 in 29 seconds
More details
- Looked at
53lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern/forge/sdk/db/id.py:157
- Draft comment:
generate_persistent_browser_session_id()should be removed as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
2. skyvern/forge/sdk/db/models.py:546
- Draft comment:
PersistentBrowserSessionModelshould be removed as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_XIERydtnax2DDqpC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Change default selection in
PromptBoxtov1, update UI descriptions, and removePersistentBrowserSessionModel.selectValueinPromptBoxfromobserverFeatureEnabled ? "v2" : "v1"to always"v1".CustomSelectItemforv1andv2inPromptBox.Skyvern 1.0 (Tasks)is now the default and described as "best for simple tasks".Skyvern 2.0 (Observer)is now secondary and described as "best for complex tasks".PersistentBrowserSessionModelandgenerate_persistent_browser_session_id()fromid.pyandmodels.py.This description was created by
for 0599892. It will automatically update as commits are pushed.