Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert playwright version #1414

Merged
merged 1 commit into from
Dec 19, 2024
Merged

revert playwright version #1414

merged 1 commit into from
Dec 19, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Dec 19, 2024

Important

Revert playwright version from 1.49.1 to 1.46.0 in pyproject.toml.

  • Dependencies:
    • Revert playwright version from 1.49.1 to 1.46.0 in pyproject.toml.

This description was created by Ellipsis for 90d8157. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 90d8157 in 18 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:21
  • Draft comment:
    Ensure that downgrading Playwright to 1.46.0 does not introduce compatibility issues with other dependencies or the codebase. Run tests to verify.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the version of Playwright from 1.49.1 to 1.46.0. This is a downgrade, and it's important to ensure that this change does not introduce compatibility issues with other dependencies or the codebase itself. However, without additional context or testing, it's difficult to ascertain the impact of this change. It's advisable to run tests to ensure everything works as expected with the older version.

Workflow ID: wflow_ahc3cCG7qqbfkpE1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit a625fe7 into main Dec 19, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/revert-playwright-version branch December 19, 2024 14:51
init-object pushed a commit to init-object/skyvern that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant