Make the workflow title a link in the workflow run page #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/'
<!-- ELLIPSIS_HIDDEN -->
> [!IMPORTANT]
> Make the workflow title a clickable link in `WorkflowRun.tsx` to improve navigation.
>
> - **UI Enhancement**:
> - In `WorkflowRun.tsx`, the workflow title is now a clickable link that navigates to `/workflows/{workflowPermanentId}/runs`.
> - Adds `Link` component with `hover:underline` styling to the title.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c939498a8580e3761096dcc79b71afb40099481b. It will automatically update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on abaebe1 in 7 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:92
- Draft comment:
Consider adding a check forworkflowPermanentIdto ensure it is not null or undefined before using it in the URL. - Reason this comment was not posted:
Confidence changes required:50%
TheLinkcomponent is used correctly, but theworkflowPermanentIdshould be checked for null or undefined values before using it in the URL.
Workflow ID: wflow_GS0neqaD7D523YvT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to abaebe1 in 7 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:90
- Draft comment:
Consider adding atitleattribute to theLinkcomponent for better accessibility. - Reason this comment was not posted:
Confidence changes required:50%
TheLinkcomponent should have atitleattribute for better accessibility.
Workflow ID: wflow_LsQEgQZBU0Gpk3py
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Make the workflow title a clickable link in
WorkflowRun.tsxfor improved navigation.WorkflowRun.tsx, the workflow title is now a clickable link that navigates to/workflows/{workflowPermanentId}/runs.Linkcomponent withhover:underlinestyling to the title.This description was created by
for abaebe1. It will automatically update as commits are pushed.