Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oncall): first deployment #494

Merged
merged 5 commits into from
Dec 5, 2024
Merged

feat(oncall): first deployment #494

merged 5 commits into from
Dec 5, 2024

Conversation

Smana
Copy link
Owner

@Smana Smana commented Oct 9, 2024

PR Type

Enhancement, Configuration changes, Dependencies


Description

  • Introduced Grafana OnCall integration with HelmReleases for RabbitMQ, OnCall, and Valkey.
  • Enhanced Victoria Metrics stack with Grafana dashboards, OAuth, and plugins.
  • Updated platform gateway and certificates to include Grafana OnCall and RabbitMQ services.
  • Added retention policy for backups in CNPG and SQL instance configurations.
  • Updated Bitnami Helm repository to use OCI format.
  • Added multiple HTTPRoutes for new services and enhanced observability configurations.

Changes walkthrough 📝

Relevant files
Dependencies
1 files
go.sum
Update Go module dependencies to latest versions.               

dagger/go.sum

  • Updated dependencies for gqlgen, grpc-gateway, testify, and others.
  • Adjusted versions to newer releases for compatibility and
    improvements.
  • +26/-26 
    Configuration changes
    14 files
    observability.yaml
    Add observability configurations for Grafana OnCall and Victoria
    Metrics.

    clusters/mycluster-0/observability.yaml

  • Added new Kustomizations for Grafana OnCall and Victoria Metrics
    stack.
  • Introduced dependencies and health checks for observability
    components.
  • Adjusted paths and timeouts for better configuration management.
  • +103/-11
    helmrelease-rabbitmq.yaml
    Add HelmRelease for RabbitMQ with monitoring and persistence.

    observability/base/grafana-oncall/helmrelease-rabbitmq.yaml

  • Added HelmRelease for RabbitMQ with configurations for authentication,
    persistence, and metrics.
  • Included Prometheus rules for monitoring RabbitMQ health and
    performance.
  • +117/-0 
    helmrelease-oncall.yaml
    Add HelmRelease for Grafana OnCall with external dependencies.

    observability/base/grafana-oncall/helmrelease-oncall.yaml

  • Added HelmRelease for Grafana OnCall with configurations for database,
    RabbitMQ, and Redis.
  • Configured external dependencies and network policies.
  • +100/-0 
    vm-common-helm-values-configmap.yaml
    Enhance Victoria Metrics stack with Grafana integration and OAuth.

    observability/base/victoria-metrics-k8s-stack/vm-common-helm-values-configmap.yaml

  • Enabled default dashboards and Grafana operator integration.
  • Added OAuth configurations for Grafana authentication.
  • Configured plugins and provisioning for Grafana.
  • +59/-6   
    platform-private-gateway.yaml
    Update platform gateway with new DNS entries.                       

    infrastructure/base/gapi/platform-private-gateway.yaml

    • Added DNS entries for Grafana OnCall and RabbitMQ services.
    +1/-1     
    kustomization.yaml
    Add Kustomization for Grafana OnCall resources.                   

    observability/base/grafana-oncall/kustomization.yaml

  • Added resources for Grafana OnCall, including secrets and
    HelmReleases.
  • +16/-0   
    main.k
    Add retention policy to CNPG backup configuration.             

    infrastructure/base/crossplane/configuration/kcl/cnpginstance/main.k

    • Added retention policy for backups in CNPG configuration.
    +7/-0     
    helmrepo-bitnami.yaml
    Update Bitnami Helm repository to OCI format.                       

    flux/sources/helmrepo-bitnami.yaml

    • Updated Bitnami Helm repository to use OCI format.
    +2/-1     
    helmrelease.yaml
    Specify namespace for Grafana Operator HelmRelease.           

    observability/base/grafana-operator/helmrelease.yaml

    • Added namespace specification for Grafana Operator HelmRelease.
    +1/-0     
    sql-instance-definition.yaml
    Add retention policy to SQL instance definition.                 

    infrastructure/base/crossplane/configuration/sql-instance-definition.yaml

    • Added retention policy field for SQL instance backups.
    +4/-0     
    httproute-oncall.yaml
    Add HTTPRoute for Grafana OnCall service.                               

    observability/base/grafana-oncall/httproute-oncall.yaml

    • Added HTTPRoute for Grafana OnCall service.
    +15/-0   
    httproute-rabbitmq.yaml
    Add HTTPRoute for RabbitMQ service.                                           

    observability/base/grafana-oncall/httproute-rabbitmq.yaml

    • Added HTTPRoute for RabbitMQ service.
    +15/-0   
    platform-private-gateway-certificate.yaml
    Update gateway certificate with new services.                       

    infrastructure/base/gapi/platform-private-gateway-certificate.yaml

  • Added certificate entries for Grafana OnCall and RabbitMQ services.
  • +2/-0     
    externalsecret-sqlinstance-password.yaml
    Add ExternalSecret for Zitadel master key.                             

    security/base/zitadel/externalsecret-sqlinstance-password.yaml

    • Added ExternalSecret for Zitadel master key.
    +22/-0   
    Additional files (token-limit)
    1 files
    gotk-components.yaml
    ...                                                                                                           

    clusters/mycluster-0/flux-system/gotk-components.yaml

    ...

    +12508/-1

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @Smana
    Copy link
    Owner Author

    Smana commented Oct 9, 2024

    /describe

    @github-actions github-actions bot added enhancement New feature or request configuration changes labels Oct 9, 2024
    Copy link
    Contributor

    github-actions bot commented Oct 9, 2024

    PR Description updated to latest commit (1e39a03)

    Copy link
    Contributor

    github-actions bot commented Oct 9, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Consistency
    The HelmRelease for RabbitMQ is configured to use a Helm chart version that might not be compatible with the specified cluster operator version. Ensure compatibility between Helm chart and operator versions.

    Resource Limits
    The resource limits for the Grafana Oncall deployment might be too low for production environments, potentially leading to performance issues.

    Typo in Key
    There is a typo in the key for the Slack app external secret, which could lead to runtime errors due to incorrect secret retrieval.

    Copy link
    Contributor

    github-actions bot commented Oct 9, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Smana Smana force-pushed the feat/oncall branch 5 times, most recently from bd8f487 to ae3ea16 Compare October 9, 2024 20:28
    @Smana Smana force-pushed the feat/oncall branch 18 times, most recently from bd15068 to 9d5a133 Compare October 25, 2024 06:50
    @Smana Smana force-pushed the feat/oncall branch 16 times, most recently from 9bfc4f2 to 59b871a Compare December 5, 2024 13:53
    @Smana
    Copy link
    Owner Author

    Smana commented Dec 5, 2024

    /describe

    Copy link
    Contributor

    github-actions bot commented Dec 5, 2024

    PR Description updated to latest commit (59b871a)

    @Smana Smana force-pushed the feat/oncall branch 7 times, most recently from 9522044 to b6baf9b Compare December 5, 2024 16:06
    @Smana Smana marked this pull request as ready for review December 5, 2024 16:08
    @Smana Smana merged commit e6af9a2 into main Dec 5, 2024
    3 checks passed
    @Smana Smana deleted the feat/oncall branch December 5, 2024 16:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants