Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made link clickable #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

made link clickable #84

wants to merge 1 commit into from

Conversation

flopp999
Copy link
Contributor

You may try it before you release it

You may try it before you release it
@Smanar
Copy link
Owner

Smanar commented Dec 13, 2020

I have tested, It works but why the "&" ?

@flopp999
Copy link
Contributor Author

I have tested, It works but why the "&" ?

I tried without & and then it get strange, if I remember correct :)
But please try without & and see what happens, maybe I had something else wrong

@Smanar
Copy link
Owner

Smanar commented Dec 13, 2020

It s removed automaticaly on my side (on windows).
No change with or without it, what is your strange thing that happen on your side ? ^^

If you are not sure make the PR on beta, will have more time to test, as I have send the PR today I forced to stop modification soon (because for exemple the domoticz plugin manager)

@flopp999
Copy link
Contributor Author

It didn't showed as a link.
Will try again w/o &

@flopp999
Copy link
Contributor Author

I didn't get a space between my text and the link, if I didn't use &

@Smanar
Copy link
Owner

Smanar commented Dec 14, 2020

I dont have space on my side without & (But making test on windows ATM)
tmp7

@flopp999
Copy link
Contributor Author

Aha OK, i have Done text in front of the link, I think that is the difference.
Nice that you implanted it 😃

@Smanar
Copy link
Owner

Smanar commented Dec 14, 2020

I have done nothing ^^, just copy/paste your code, it s for that I don't understand why it don't work on your side.
Have just removed or not the "&", but it s removed on final code when the page is displayed

And it s not on the last official yet, I will put it in the beta, now it s too late, if I change the code again, it will trigger a new update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants