-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX audit: landing page and navigation #280
base: develop
Are you sure you want to change the base?
Conversation
git-subtree-dir: packages/website git-subtree-split: 9885a846b9529c7613232e12ec46aab76cd3fda9
git-subtree-dir: packages/docs git-subtree-split: c63fea5f0963c0c9dbd104180f75cea8033e53ca
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks like you gotta run a |
@dan13ram @scottrepreneur |
@CJ-Rose You can see the build fails locally if you run you would have to run Here is a screenshot from vercel I have a feeling its because of version mismatch between the different packages and corresponding issues with node_modules.. Can you run Particularly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan13ram finally, a successful build 😅
want to point out these 2 changes, as they are the only updates to files outside of /website
and /docs
'react/jsx-filename-extension': [2, { extensions: ['.ts', '.tsx'] }], | ||
'react/jsx-filename-extension': [2, { extensions: ['.js', '.jsx', '.ts', '.tsx'] }], | ||
'react/function-component-definition': 'off', | ||
"react/no-array-index-key": "off", | ||
"react/jsx-props-no-spreading": "off", | ||
"no-use-before-define": "off", | ||
"import/no-default-export": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these rules were added to allow /website
to build after Next update from v12 to v14, without requiring major code rewrites.
"deploy-zap": "hardhat run scripts/deploy-zap.ts --network", | ||
"flatten-all": "yarn flatten-factory && yarn flatten-instant && yarn flatten-escrow && yarn flatten-updatable && yarn flatten-spoils && yarn flatten-zap && yarn flatten-dao-zap", | ||
"flatten-all": "mkdir -p flat && yarn flatten-factory && yarn flatten-instant && yarn flatten-escrow && yarn flatten-updatable && yarn flatten-spoils && yarn flatten-zap && yarn flatten-dao-zap", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required to execute pnpm -r build
, build fails if /flat
directory does not yet exist.
No description provided.