Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX audit: landing page and navigation #280

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

UX audit: landing page and navigation #280

wants to merge 27 commits into from

Conversation

CJ-Rose
Copy link
Member

@CJ-Rose CJ-Rose commented Dec 16, 2024

No description provided.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-invoice-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 7:23pm

@dan13ram
Copy link
Collaborator

Looks like you gotta run a pnpm install and commit the latest lock file. Thats why the build is failing on vercel @CJ-Rose

@CJ-Rose CJ-Rose linked an issue Dec 16, 2024 that may be closed by this pull request
@CJ-Rose
Copy link
Member Author

CJ-Rose commented Dec 16, 2024

Looks like you gotta run a pnpm install and commit the latest lock file. Thats why the build is failing on vercel @CJ-Rose

@dan13ram @scottrepreneur
new lock file committed but build still fails, please investigate?
otherwise this PR is ready for review.

@dan13ram
Copy link
Collaborator

@CJ-Rose You can see the build fails locally if you run pnpm -r build in the root dir.

you would have to run pnpm prepare-sepolia && pnpm codegen in packages/subgraph before you can run pnpm -r build in the root dir (just to ensure build passes for the subgraph directory)

Here is a screenshot from vercel

image

I have a feeling its because of version mismatch between the different packages and corresponding issues with node_modules..

Can you run pnpx syncpack list-mistmatches on the root directory? It will show you all the package version mismatches.
You can then run pnpx syncpack fix-mismatches to fix it. You may have to make some changes post that to ensure the build succeeds.

Particularly next and some eslint package versions differ between dapp and website which may be causing this issue.

Copy link
Member Author

@CJ-Rose CJ-Rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan13ram finally, a successful build 😅

want to point out these 2 changes, as they are the only updates to files outside of /website and /docs

Comment on lines -53 to +58
'react/jsx-filename-extension': [2, { extensions: ['.ts', '.tsx'] }],
'react/jsx-filename-extension': [2, { extensions: ['.js', '.jsx', '.ts', '.tsx'] }],
'react/function-component-definition': 'off',
"react/no-array-index-key": "off",
"react/jsx-props-no-spreading": "off",
"no-use-before-define": "off",
"import/no-default-export": "off",
Copy link
Member Author

@CJ-Rose CJ-Rose Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these rules were added to allow /website to build after Next update from v12 to v14, without requiring major code rewrites.

Comment on lines 52 to +53
"deploy-zap": "hardhat run scripts/deploy-zap.ts --network",
"flatten-all": "yarn flatten-factory && yarn flatten-instant && yarn flatten-escrow && yarn flatten-updatable && yarn flatten-spoils && yarn flatten-zap && yarn flatten-dao-zap",
"flatten-all": "mkdir -p flat && yarn flatten-factory && yarn flatten-instant && yarn flatten-escrow && yarn flatten-updatable && yarn flatten-spoils && yarn flatten-zap && yarn flatten-dao-zap",
Copy link
Member Author

@CJ-Rose CJ-Rose Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required to execute pnpm -r build, build fails if /flat directory does not yet exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX audit: Landing page and navigation
3 participants