-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
copy-editing, and fixing the first 4 out of 5 problems in feedback:
1. Is this scriptURI() unique in one smart contract? For example, in NFT smart contract can we define one scriptURI() per one tokenId? ** something like mapping(tokenId => scriptURI) 2. Regarding scriptURI struct, can we store hash of uri for transparency? It's some thing like below struct ScriptURI { string uri; bytes32 scriptHash // for Authenticity // user can know if he executes correct script } 3. In variables script: The script supplying additional functionality to the tokens. ??? is it different from scriptURI? 4. In IERC 5XX0 interface interface IERC5XX0 { /// @dev Mee This event emits when the scriptURI is updated, /// so wallets implementing this interface can update a cached script event ScriptUpdate(string[] memory newScriptURI); /// @notice Get the scriptURI for the contract /// @return The scriptURI function scriptURI() external view returns(string[] memory); /// @notice Update the scriptURI /// emits event ScriptUpdate(scriptURI memory newScriptURI); function setScriptURI(string[] memory newScriptURI, bytes memory newSigScriptURI) external; } function setScriptURI(string[] memory newScriptURI, bytes memory newSigScriptURI) external; == What is newSigScriptURI? 5. The smart contract implementing IERC5XX0 MUST set owner=msg.sender in its constructor. == Does it means ownership is immutable in this smart contract? why only msg.sender?
- Loading branch information
Weiwu Zhang
committed
Jun 16, 2022
1 parent
b09f0e3
commit b27266e
Showing
1 changed file
with
49 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters