Take OwnedFd instead of RawFd as argument to receive_to_fd
#408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be the only use of `RawFd` in a public API. With this change, these functions should be safe to call. I'm not sure if it would make more sense for these functions to not close the file descriptor. In which case they could take `BorrowedFd`. But this matches the current implementation, but with an IO safe type.
wash2
approved these changes
Sep 22, 2023
|
Ah, I guess it does make sense to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be the only use of
RawFdin a public API. With this change, these functions should be safe to call.I'm not sure if it would make more sense for these functions to not close the file descriptor. In which case they could take
BorrowedFd. But this matches the current implementation, but with an IO safe type.