Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try alternative cursor icon names #427

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

Friz64
Copy link
Contributor

@Friz64 Friz64 commented Nov 2, 2023

Try the standardized cursor icon name, followed by a list of alternative cursor icon names (provided through rust-windowing/cursor-icon#11).

See also:

cc @kchibisov

Fixes #425

@Friz64
Copy link
Contributor Author

Friz64 commented Nov 2, 2023

Testing with the themed-window example on my machine, it now almost works perfectly, except for a few cursor icons that are still missing in my theme. For example, setting the vertical-text cursor still returns CursorNotFound. In this case, it might be beneficial to display a horizontal text cursor as a best effort. Assuming this is to be implemented, would handling this be the job of Smithay's Client Toolkit or would this behaviour be implemented in (e.g.) winit?

@kchibisov
Copy link
Member

it now almost works perfectly, except for a few cursor icons that are still missing in my theme.

Not our issue. fix your theme, as I said. The cursor which should be used in such case is the one active at the moment, it's consistent with gtk, etc iirc.

Cargo.toml Outdated Show resolved Hide resolved
src/seat/pointer/mod.rs Outdated Show resolved Hide resolved
@Friz64 Friz64 marked this pull request as ready for review November 2, 2023 16:56
@wash2 wash2 merged commit e63ab5f into Smithay:master Nov 2, 2023
6 checks passed
@Friz64 Friz64 deleted the alt-cursor-names branch November 2, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor Icon Regression on GNOME
3 participants