Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix session lock example and add more explanations #463

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

happenslol
Copy link
Contributor

The example would previously show a solid color for 1.5s, after which the lock surfaces were created. With multiple displays, the surfaces would sometimes not be created at all.

The issue here is that the compositor expects a surface to be created for each display before locked is called, and since the example only creates the surfaces in locked the compositor would time out waiting for the surfaces, resulting in the placeholder solid color screen.

I've also added some more comments, clarifying some things that I ran into while trying to use the protocol myself.

Lastly, I've changed the finished log, since from my understanding, finished is only called if the session failed to be locked, and will not be called if the session is locked and unlocked normally.

@wash2 wash2 merged commit 0233ee6 into Smithay:master Aug 27, 2024
6 of 7 checks passed
@happenslol happenslol deleted the fix-session-lock-example branch August 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants