fix: Fix session lock example and add more explanations #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example would previously show a solid color for 1.5s, after which the lock surfaces were created. With multiple displays, the surfaces would sometimes not be created at all.
The issue here is that the compositor expects a surface to be created for each display before
locked
is called, and since the example only creates the surfaces inlocked
the compositor would time out waiting for the surfaces, resulting in the placeholder solid color screen.I've also added some more comments, clarifying some things that I ran into while trying to use the protocol myself.
Lastly, I've changed the
finished
log, since from my understanding,finished
is only called if the session failed to be locked, and will not be called if the session is locked and unlocked normally.