Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frame a seperate method of PointerTarget/PointerGrab #1137

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Sep 19, 2023

Input handling in compositors will have to emit this appropriatly. But then other methods don't have to map perfectly to frames.

Meant to address #1126.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks in principle good to me. 👍

This obviously also needs updates to smallvil and possibly wlcs_anvil and some examples. Also an entry in the changelog.

@ids1024 ids1024 force-pushed the frame branch 3 times, most recently from 101e37a to 5ef839d Compare September 21, 2023 20:29
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 40.25% and project coverage change: +0.06% 🎉

Comparison is base (58d5bdc) 22.87% compared to head (4c37923) 22.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
+ Coverage   22.87%   22.93%   +0.06%     
==========================================
  Files         144      144              
  Lines       23317    23375      +58     
==========================================
+ Hits         5333     5362      +29     
- Misses      17984    18013      +29     
Flag Coverage Δ
wlcs-buffer 19.84% <0.00%> (-0.05%) ⬇️
wlcs-core 19.49% <0.00%> (-0.05%) ⬇️
wlcs-output 8.25% <0.00%> (-0.03%) ⬇️
wlcs-pointer-input 21.73% <40.25%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
anvil/src/input_handler.rs 7.31% <0.00%> (-0.03%) ⬇️
anvil/src/shell/grabs.rs 0.00% <0.00%> (ø)
src/desktop/wayland/layer.rs 7.09% <0.00%> (-0.05%) ⬇️
src/desktop/wayland/popup/grab.rs 0.00% <0.00%> (ø)
src/input/mod.rs 50.60% <ø> (ø)
src/wayland/data_device/dnd_grab.rs 0.00% <0.00%> (ø)
src/wayland/data_device/server_dnd_grab.rs 0.00% <0.00%> (ø)
src/wayland/pointer_gestures.rs 0.00% <ø> (ø)
src/wayland/relative_pointer.rs 0.00% <ø> (ø)
wlcs_anvil/src/main_loop.rs 68.96% <27.27%> (-0.45%) ⬇️
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Input handling in compositors will have to emit this appropriatly. But
then other methods don't have to map perfectly to frames.

Meant to address Smithay#1126.
@ids1024 ids1024 marked this pull request as ready for review September 21, 2023 22:02
@Drakulix Drakulix merged commit d3e1ef9 into Smithay:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants