DPO3DPKRT-864/Notification Emails #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(new) send email routines via notifyEmail (new) support for multiple recipients (new) support for html body with text fallback (new) support for embedded image/icon from message type (new) robust server response handling (fix) convertToIOResults not handling errors correctly (fix) log 'data' is optional
(new) place Notify email functionality in class and cleanup exports
(new) email rate management (new) Notify class with configuration (new) return type for onPost in RateManager (new) added type to NotifyPackage
(fix) explicit calls to Logger vs. dynamic this. resolves 'this' binding
(new) asynchronous calling for Logger + Notify (new) defined fromAddress pointing to [email protected] (fix) cleaner error handling and bubbling up of status (fix) cleaned up return types (fix) removed onMessage in RateManager. Messages attach to promise (fix) commented console handling in legacy Logger for cleaner debugging.
(new) dynamic burst mode and maintained threshold (new) metrics for average rates and counts (fix) removed obsolete staggerLogs
(new) start/stop/cleanup for the manager (new) added 'rates' to available metrics (new) debugMode for additional details (stdout) (fix) more robust and efficient metrics tracking (fix) exposed metrics structure
(new) optional base64 images for Emails. defaults to URL (fix) rate calculations for metrics
(new) testEmail in NotifyEmail and RecordKeeper
(fix) using packrat emails: packrat-dev & packrat-noreply (fix) override email address for generic email sending
(new) generic naming and routine for getting icon URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification support sending emails
Legacy Logger