Fix Alert TTL handled column updation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-afedorov
requested changes
May 1, 2024
procedures_js/alert_dispatcher.js
Outdated
| CASE | ||
| WHEN ? < TIMEADD(MINUTES, -$${handler_ttl}, CURRENT_TIMESTAMP) | ||
| THEN OBJECT_CONSTRUCT('success', FALSE, 'details', 'Alert TTL expired.') | ||
| ELSE $${handler_name}(PARSE_JSON(?), PARSE_JSON(?)) |
There was a problem hiding this comment.
I think this logic might need to go into JavaScript because SQL is not procedural language, with an assumption that even case clauses are functional (without side effects) and so this code might be compiled to run on multiple processors with the handler being evaluated before the predicates are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps update the handled column if an alert is past its TTL. It:
GET_HANDLERSquery and returns all the alerts irrespective of them being past their TTL