Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[splib3] Adds features and one fix #116

Merged

Conversation

EulalieCoevoet
Copy link
Member

In numerics:

  • adds to_degrees() function
  • fixes createFromEuler (was modifing the parameter rotation, which is by default given by reference in python)

In animation:

  • adds endTime option

- adds to_degrees() to numerics __init__
- adds endTime to animate.py
- fixed createFromEuler (was modifing the parameter rotation, which is by default given by reference in python)
@damienmarchal
Copy link
Member

damienmarchal commented Dec 14, 2023

Hi @EulalieCoevoet

Thanks for the PR.

Could you elaborate a bit more the use case for the endTime parameter in animate.
It is unclear to me what is its purpose and if its name reflects what it does.

@EulalieCoevoet
Copy link
Member Author

It allows to synchronize and loop multiple animations.

@EulalieCoevoet
Copy link
Member Author

Let's say you have an animation, with a duration of 2s but you want it to play again or rewind every 4s, you'll set :

  • startTime = 0
  • duration = 2
  • endTime = 4

@damienmarchal What do you think ?

@EulalieCoevoet
Copy link
Member Author

What about endDelay with the corresponding new implementation ?

@EulalieCoevoet
Copy link
Member Author

EulalieCoevoet commented Apr 16, 2024

@damienmarchal I've made the changes and added an exemple :)

@EulalieCoevoet
Copy link
Member Author

@damienmarchal can we merge?

Note: the params field is for passing parameters to the
callback function not for controlling the animation system itself.
@damienmarchal
Copy link
Member

damienmarchal commented May 22, 2024

@EulalieCoevoet it is ok to me, i just change the code so the parameter is passed as "duration".
If ok to you, you can merge the PR.

@EulalieCoevoet EulalieCoevoet merged commit 232e96e into SofaDefrost:master May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants