-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[splib3] Adds features and one fix #116
[splib3] Adds features and one fix #116
Conversation
- adds to_degrees() to numerics __init__ - adds endTime to animate.py - fixed createFromEuler (was modifing the parameter rotation, which is by default given by reference in python)
Thanks for the PR. Could you elaborate a bit more the use case for the endTime parameter in animate. |
It allows to synchronize and loop multiple animations. |
Let's say you have an animation, with a duration of 2s but you want it to play again or rewind every 4s, you'll set :
@damienmarchal What do you think ? |
What about |
@damienmarchal I've made the changes and added an exemple :) |
@damienmarchal can we merge? |
Note: the params field is for passing parameters to the callback function not for controlling the animation system itself.
@EulalieCoevoet it is ok to me, i just change the code so the parameter is passed as "duration". |
In numerics:
In animation: