DATAGO-83040: Support Rolling Update #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudraneel-chakraborty
had a problem deploying
to
build_pr
GitHub Actions
Failure
rudraneel-chakraborty
changed the title
|
|
||
| String hostNameHash = DigestUtils.sha256Hex(hostName); | ||
| String agentId = eventPortalProperties.getRuntimeAgentId(); | ||
| return String.format("%s-%s", agentId, hostNameHash); |
There was a problem hiding this comment.
Hash because
Comment on lines
+70
to
+71
| String clientName = StringUtils.isEmpty(computedClientName) ? | ||
| "runtimeAgent-" + eventPortalProperties.getRuntimeAgentId() : computedClientName; |
There was a problem hiding this comment.
Falls back on the ep core generated client name if EMA is having trouble determining its own client name based on host name.
In other words, we are following precedence here
- EMA tries to generate its own client name
- If it cannot, then it uses the one generated by ep core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
How was this change implemented?
How was this change tested?
Is there anything the reviewers should focus on/be aware of?