DATAGO-79385: update opentofu and solace provider #203
Conversation
moodiRealist
requested review from
mynecker,
CameronRushton and
rudraneel-chakraborty
moodiRealist
temporarily deployed
to
build_pr
GitHub Actions
Inactive
| ADD terraform-provider-solacebroker_${SOLACE_PROVIDER_VERSION}_${PLATFORM}.zip /opt/ema/terraform | ||
|
|
There was a problem hiding this comment.
why zip file?
you could use .tar and just use add (I think add also works with zip)
There was a problem hiding this comment.
Because this version 1.0.1 only had the zip format available.
As for the command I followed the steps from this confluence page. Please let me know if that's wrong instruction!
There was a problem hiding this comment.
The ADD command already extracts content no?
the point I am trying to make is most likely, you do not need the unzip command https://docs.docker.com/build/building/best-practices/#add-or-copy
There was a problem hiding this comment.
I tested removing the unzip command:
The result was that I will be missing the terraform-provider if I do that:
moodiRealist
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
What is the purpose of this change?
To address MEND vulnerability reports
How was this change implemented?
Replaced openTofu and solace's terraform provider with newer versions.
How was this change tested?
From the latest changes of this PR, test configPush and Scans on macbook, windows, and cloudManaged:
Is there anything the reviewers should focus on/be aware of?
Nope.