Release v1.8.1 #27
Merged
Release v1.8.1 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
links against CCSMP, it treats all opaque pointers as uintptrs (effectively longs) instead of as void pointers, except for solClient_opaquePtr_pt. I couldn't figure out how to get around solClient_opaquePtr_pt because certain CCSMP functions like solClient_msg_getBinaryAttachmentPtr require a pointer to an opaque pointer. This was all done to avoid the cgo runtime from panicking when it does a runtime check of a C/Go boundary and believes that the 'void *' type that the opaque pointers used to be typedef'd to was an unpinned pointer. As mentioned, the change to the typdef of opaque pointers in solClient.h will prevent the cgo runtime from panicking since it will evaluate the opaque pointers as longs/ints instead of unpinned references. It's unclear whether or not the solClient_opaquePtr_pt will become a problem in the future, but it is actually pointing to data whereas the other solClient_opaque*_pt types are not, which the cgo runtime should be able to discern. The other changes made in this commit were in response to the typdef change, and isolating more memory allocation of configuration structs like the sessionCreateFuncInfo to C in order to mitigate the risk of bad references being accessed by CCSMP.
included when compiling for the Go API.
EBP-383: Fix runtime cgo panic by changing CCSMP opaque pointer typdefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for go runtime cgo unpinned go pointers issues.