Changed order of condition, check for parse errors first

SolaceProducts · Nov 7, 2024 · d6f016e · d6f016e
1 parent 793b7f3
commit d6f016e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/internal/broker/utilities.go b/internal/broker/utilities.go
@@ -176,12 +176,12 @@ func client(providerData *providerData) (*semp.Client, diag.Diagnostic) {
 		}
 	}
 	url, err := stringWithDefaultFromEnv(providerData.Url, "url")
-	if url == "" {
-		return nil, diag.NewErrorDiagnostic("`url` attribute must be defined in a provider block or set as an environment variable (`SOLACEBROKER_URL`)", semp.ErrProviderParametersError.Error())
-	}
 	if err != nil {
 		return nil, diag.NewErrorDiagnostic("Unable to parse provider attribute", err.Error())
 	}
+	if url == "" {
+		return nil, diag.NewErrorDiagnostic("`url` attribute must be defined in a provider block or set as an environment variable (`SOLACEBROKER_URL`)", semp.ErrProviderParametersError.Error())
+	}
 	retries, err := int64WithDefaultFromEnv(providerData.Retries, "retries", semp.DefaultRetries)
 	if err != nil {
 		return nil, diag.NewErrorDiagnostic("Unable to parse provider attribute", err.Error())