Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/imx8m_image.sh: remove bashism #4

Open
wants to merge 62 commits into
base: v2018.11-solidrun
Choose a base branch
from

Conversation

baruchsiach
Copy link

Use a single '=' to test string equality for compatibility with non-bash
shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator
./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator
./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator
./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator
WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

Signed-off-by: Baruch Siach [email protected]

Junlisuzhou and others added 30 commits November 28, 2018 08:37
imx8mq usb xhci is a dwc3 based controller, its synopsys PHY
can be controlled by usbmix glue layer. imx8mq has 2 USB3 instance,
this patch only enables USB2(2nd instance).

Reviewed-by : Peng Fan <[email protected]>
Signed-off-by: Li Jun <[email protected]>
ATF will power off all PUs at default, so for USB, we enable
its PU power for both host and device modes in board_usb_init and
disable the power when usb is stop in board_usb_cleanup.

Signed-off-by: Ye Li <[email protected]>
Reviewed-by: Li Jun <[email protected]>
Fix build warnings below, because the imx8m_usb_power is not declared

board/freescale/imx8mq_evk/imx8m_evk.c: In function ‘board_usb_init’:
board/freescale/imx8mq_evk/imx8m_evk.c:205:2: warning: implicit
declaration of function ‘imx8m_usb_power’ [-Wimplicit-function-declaration]
  imx8m_usb_power(index, true);
  ^~~~~~~~~~~~~~~

drivers/usb/host/xhci-imx8m.c: In function ‘xhci_hcd_init’:
drivers/usb/host/xhci-imx8m.c:123:3: warning: implicit declaration of
function ‘imx8m_usb_power’ [-Wimplicit-function-declaration]
   imx8m_usb_power(ctr_data[index].usb_id, false);
   ^~~~~~~~~~~~~~~

Signed-off-by: Ye Li <[email protected]>
Acked-by: Peng Fan <[email protected]>
i.MX8MQ has two USB3 controllers. Previously we only added the u-boot#2
controller support in driver. This patch adds the address for u-boot#1
controller.

Signed-off-by: Ye Li <[email protected]>
Acked-by: Jun Li <[email protected]>
(cherry picked from commit 3172dab)
There are some integer to pointer convert. To support 64 bits system,
change the unsigned int to unsigned long.

Signed-off-by: Ye Li <[email protected]>
Adding basic HDMI support for i.MX8 for splash screen.

Signed-off-by: Oliver Brown <[email protected]>
This adds a command to load the HDP firmware and supporting libraries.

Signed-off-by: Oliver Brown <[email protected]>
…t selected

Met build errors below when CONFIG_VIDEO_IMX_HDP_LOAD is not selected. Because the u-boot
make script checks the "$(obj-y) $(obj-m) $(obj-) $(subdir-m) $(lib-target)" for built-in target.

aarch64-poky-linux-ld.bfd: cannot find drivers/video/imx/built-in.o: No such file or directory
scripts/Makefile.build:359: recipe for target 'drivers/video/built-in.o' failed

Signed-off-by: Ye Li <[email protected]>
Reviewed-by: Peng Fan <[email protected]>
Renaming hdpload to hdp_load for consistancy.
Correcting the strncmp to use only 4 characters to match "load" argument

Signed-off-by: Oliver Brown <[email protected]>
Adding HDMI support for splash screen.

Signed-off-by: Oliver Brown <[email protected]>
Adding header file for i.MX8 HDMI support

Signed-off-by: Oliver Brown <[email protected]>
Checks whether the HDMI FW is running before initialize the HDMI display.
So that for cases like mfgtool and imx-boot image without HDMI FW, the
u-boot won't be blocked.

Signed-off-by: Ye Li <[email protected]>
(cherry picked from commit 273b45d)
Adding i.MX8 HDMI support to build configuration.

Signed-off-by: Oliver Brown <[email protected]>
Signed-off-by: Troy Kisky <[email protected]>
Adding the HDP firmware loading to the build.

Signed-off-by: Oliver Brown <[email protected]>
tkisky and others added 29 commits November 28, 2018 20:15
The script currently doesn't use the standard distro variables.

Signed-off-by: Gary Bisson <[email protected]>
pending patch imx: rename mx8m,MX8M to imx8m,IMX8M failed
to change a few Kconfig options that depended on the MX8M naming.
This updates them to reflect the proposed patch.

Signed-off-by: Jon Nettleton <[email protected]>
Add imx8mq_hb support which is the first i.MX8MQ based board
from SolidRun.  This commit is based on the support that has
already or been merged upstream, including the soon to be merged
lpddr4 initialization code.

U-Boot SPL 2018.11-00058-g517ec4c76c (Nov 28 2018 - 20:01:44 +0100)
PMIC:  PFUZE100 ID=0x10
Normal Boot
Trying to boot from MMC2
NOTICE:  Configureing TZASC380
NOTICE:  BL31: v1.6(release):v1.6-110-gb86481c5
NOTICE:  BL31: Built : 09:03:59, Sep 30 2018
NOTICE:  sip svc init

U-Boot 2018.11-00058-g517ec4c76c (Nov 28 2018 - 20:01:44 +0100)

CPU:   Freescale i.MX8MQ rev2.0 at 1000 MHz
Reset cause: POR
Model: SolidRun i.MX8MQ HummingBoard Pulse
DRAM:  3 GiB
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
Loading Environment from MMC... OK
In:    serial
Out:   serial
Err:   serial
Net:
Error: ethernet@30be0000 address not set.

Signed-off-by: Jon Nettleton <[email protected]>
Otherwise can't boot the M4 core as it is impossible to load its
firmware into the TCM memory.

Signed-off-by: Gary Bisson <[email protected]>
Reviewed-by: Peng Fan <[email protected]>
Using ulong is wrong as its size depends on the Host CPU architecture
(32-bit vs. 64-bit) although the Cortex-M4 is always 32-bit.

Without this patch, the stack and PC are obviously wrong and it
generates an abort when used on 64-bit processors such as the i.MX8MQ.

Signed-off-by: Gary Bisson <[email protected]>
Reviewed-by: Peng Fan <[email protected]>
Some dwc3 based USB3 IP may have a wrong default suspend clk
setting, so add an interface to correct it by board setting.

Acked-by: Peng Fan <[email protected]>
Signed-off-by: Li Jun <[email protected]>
Need to pass total 5 arguments for SIP HAB call, so update the interface
to add new argument.

Signed-off-by: Ye Li <[email protected]>
This is marked up build instructions for generating a bootable
FIT Image for the iMX8M based SolidRun Products

Signed-off-by: Jon Nettleton <[email protected]>
Missed a spelling error
Add an simple driver for USB typec port controller in freescale common codes.
The functions in this driver help to initialize the TCPC, set and work with
fixed DFP role.

Will improve it later to support UFP and move to driver directory.

Signed-off-by: Ye Li <[email protected]>
To add support for power sink when booting in dead battery, we
have to setup PD connection with PD source and send/receive PD messages
to negotiate a proper voltage and current.

This patch refactors the TCPC driver with this new function and also
keep DFP mode support for USB host.

Signed-off-by: Ye Li <[email protected]>
Acked-by: Jun Li <[email protected]>
Some power delivery source send the source capability by 2 stages:
1st stage send the source capability message with only basic 5V
PDO, after the 5V power session setup, 2nd stage it will send full
source capabilities with all PDOs it can support, in this case, we
should go on to process the following PD source cap to have a new
power session setup.

Signed-off-by: Li Jun <[email protected]>
Add a interface to set UFP mode, so when running as device mode, the
board level codes can use it to configure the TCPC port to UFP mode.

Since we have supported PD charge for dead battery, so add check before
applying UFP or DFP mode.

Signed-off-by: Ye Li <[email protected]>
Acked-by: Jun Li <[email protected]>
Remove a non-existant reset pin for the SDHC2.

Signed-off-by: Jon Nettleton <[email protected]>
This patch is important as currently Linux is not initializing the
USB clocks correctly, so if we don't do it u-boot USB host mode
does not work.  This is a temporary fix until the Linux kernel is
patched to work properly.

Regardless we want USB working properly for booting and recovering
our board, although this needs to be converted to a DM driver model.

Signed-off-by: Jon Nettleton <[email protected]>
This is a follow up patch to 1e365ab

Signed-off-by: Jon Nettleton <[email protected]>
This reverts commit ae5de28.

Revert this for now as it breaks other platforms that do not use
a sys_proto.h header.

Signed-off-by: Jon Nettleton <[email protected]>
This include seems to be unneccesary and broke builds for now
mvebu platforms.  Removing this include allows both to build.

Signed-off-by: Jon Nettleton <[email protected]>
This adds a generic controller function to handle the various
GPC power regions.  For the HB Pulse we use this to power off
both PCIE regions on boot to help return the devices to a sane
state on reboot and sudden power off.

Signed-off-by: Jon Nettleton <[email protected]>
Use a single '=' to test string equality for compatibility with non-bash
shells. Otherwise, if /bin/sh is dash, build fails:

./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator
./tools/imx8m_image.sh: 15: [: signed_hdmi_imx8m.bin: unexpected operator
./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator
./tools/imx8m_image.sh: 15: [: spl/u-boot-spl-ddr.bin: unexpected operator
WARNING './spl/u-boot-spl-ddr.bin' not found, resulting binary is not-functional

Signed-off-by: Baruch Siach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants