-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imp maintenance screen #108
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Marta <[email protected]>
Co-authored-by: Marta <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/> | ||
)} | ||
|
||
{/*<Route path="*" element={<Maintenance {...props} />} />*/} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is commented,It is wright? Id not this line bd the correspondent import should be removed.
element={ | ||
<GurbErrorContextProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be a rebase is necessary
import React, { useState, createContext } from 'react' | ||
import Maintenance from '../components/Maintenance' | ||
|
||
const AvailabilityContext = createContext() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COMMENT: maybe add a reference to availability of backend? AvailabilityContext seams too generic, no?
Description
Replace forms by maintenance screen if ping request fails
Changes
AvailabilityContext
andAvailabilityContextProvider
ApiStatus
and only use its logicChecklist
Justify any unchecked point:
CHANGES.md
file.Observations
👀
Please, review
🤷
How to check the new features
🏓⛓️💥🕳️ ➡️⁉️
Deploy notes
🎲🙏