Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp maintenance screen #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Imp maintenance screen #108

wants to merge 3 commits into from

Conversation

BenjiRS94
Copy link
Contributor

@BenjiRS94 BenjiRS94 commented Dec 10, 2024

Description

Replace forms by maintenance screen if ping request fails

Changes

  • AvailabilityContext and AvailabilityContextProvider
  • Removed React component from ApiStatus and only use its logic

Checklist

Justify any unchecked point:

  • Changed code is covered by tests.
  • Relevant changes are explained in the "Unreleased" section of the CHANGES.md file.
  • That section includes "Upgrade notes" with any config, dependency or deploy tweek needed on development and server setups.
  • Changes on the setup process (development, testing, production) have been updated in the proper documentation

Observations

👀

Please, review

🤷

How to check the new features

🏓⛓️‍💥🕳️ ➡️ ⁉️

Deploy notes

🎲🙏

Benji and others added 2 commits December 9, 2024 14:18
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webforms-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:03am

/>
)}

{/*<Route path="*" element={<Maintenance {...props} />} />*/}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is commented,It is wright? Id not this line bd the correspondent import should be removed.

element={
<GurbErrorContextProvider>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be a rebase is necessary

import React, { useState, createContext } from 'react'
import Maintenance from '../components/Maintenance'

const AvailabilityContext = createContext()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMENT: maybe add a reference to availability of backend? AvailabilityContext seams too generic, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants