Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Custom CSPROJ #11

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Enhancement: Custom CSPROJ #11

merged 2 commits into from
Feb 22, 2024

Conversation

AndrewDRX
Copy link
Contributor

Pull request for issue #10.

Feel free to just use this pull request as inspiration for another commit if you want it structured a bit different than I have it.

@AndrewDRX AndrewDRX deleted the branch SomeRanDev:development February 18, 2024 22:31
@AndrewDRX AndrewDRX closed this Feb 18, 2024
@AndrewDRX AndrewDRX deleted the development branch February 18, 2024 22:31
@AndrewDRX AndrewDRX restored the development branch February 18, 2024 22:32
@AndrewDRX AndrewDRX reopened this Feb 18, 2024
@SomeRanDev
Copy link
Owner

Sorry for the delay! Was waiting on @jeremyfa's printer rework before accepting, but will do now since that might take a bit longer.

For future reference, I think we should only use underscores for define names since dashes break compatibility with conditional compilation. (ie: #if no-csproj doesn't work afaik?) Even if we don't use a define like this, some Reflaxe/C# users might? I know official Haxe defines are inconsistent, but no reason we should be? 😅

@SomeRanDev SomeRanDev merged commit 0428f02 into SomeRanDev:development Feb 22, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
@AndrewDRX
Copy link
Contributor Author

Sorry for the delay! Was waiting on @jeremyfa's printer rework before accepting, but will do now since that might take a bit longer.

For future reference, I think we should only use underscores for define names since dashes break compatibility with conditional compilation. (ie: #if no-csproj doesn't work afaik?) Even if we don't use a define like this, some Reflaxe/C# users might? I know official Haxe defines are inconsistent, but no reason we should be? 😅

Sounds good! Although, the csproj define is the only new one here. The no-csproj define already existed, I just added more structure around it by adding it to the Define enum so there would be consistency when checking for both of them in setupCsProj(). But I will keep that on my radar to switch it to no_csproj at some point if no one else gets to it before me.

@jeremyfa
Copy link
Collaborator

Could have been me who added that option I don't remember, but I completely agree with using underscores instead of dashes 👍

@SomeRanDev
Copy link
Owner

OH SORRY! In retrospect, I'm almost 100% sure I added that, and I forgot about it until seeing this. I just wanted to give an explanation so it didn't seem like I was changing things randomly after merging. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants