-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
9 changed files
with
220 additions
and
127 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| # Contributing to Grav External Links plugin | ||
|
|
||
| Please take a moment to review this document in order to make the contribution process easy and effective for everyone involved. | ||
|
|
||
| Following these guidelines helps to communicate that you respect the time of the developers managing and developing this open source project. In return, they should reciprocate that respect in addressing your issue or assessing patches and features. | ||
|
|
||
| ## Using the issue tracker | ||
|
|
||
| The issue tracker is the preferred channel for [bug reports](#bugs), [features requests](#features) and [submitting pull requests](#pull-requests), but please respect the following restrictions: | ||
|
|
||
| * Please format your issue using [GitHub's markdown syntax and features][markdown]. | ||
|
|
||
| * Please **do not** use the issue tracker for personal support requests (use [Stack Overflow](http://stackoverflow.com) or IRC). | ||
|
|
||
| * Please **do not** derail or troll issues. Keep the discussion on topic and respect the opinions of others. | ||
|
|
||
| As a courtesy to avoid sending notifications to any user that might have the `@username` being referenced, please remember that GitHub usernames also start with the at sign and therefore wrap words that begin with the at sign (`@`) in backticks. | ||
|
|
||
| <a id="bugs"></a> | ||
| ## Bug reports | ||
|
|
||
| A bug is a _demonstrable problem_ that is caused by the code in the repository. Good bug reports are extremely helpful - thank you! | ||
|
|
||
| Guidelines for bug reports: | ||
|
|
||
| 1. **Use the GitHub issue search** — check if the issue has already been reported. | ||
|
|
||
| 2. **Check if the issue has been fixed** — try to reproduce it using the latest `master` or development branch in the repository. | ||
|
|
||
| 3. **Isolate the problem** — create a [reduced test case](http://css-tricks.com/6263-reduced-test-cases/) and a live example that should be included in each bug report. | ||
|
|
||
| A good bug report shouldn't leave others needing to chase you up for more information. Please try to be as detailed as possible in your report. What is your environment? What steps will reproduce the issue? What browser(s) and OS experience the problem? What would you expect to be the outcome? All these details will help people to fix any potential bugs. | ||
|
|
||
| _Example:_ | ||
|
|
||
| > Short and descriptive example bug report title | ||
| > | ||
| > A summary of the issue and the browser/OS environment in which it occurs. If | ||
| > suitable, include the steps required to reproduce the bug. | ||
| > | ||
| > 1. This is the first step | ||
| > 2. This is the second step | ||
| > 3. Further steps, etc. | ||
| > | ||
| > `<url>` - a link to the reduced test case | ||
| > | ||
| > Any other information you want to share that is relevant to the issue being | ||
| > reported. This might include the lines of code that you have identified as | ||
| > causing the bug, and potential solutions (and your opinions on their | ||
| > merits). | ||
| Last but not least, if you have a solution or suggestion for how to fix the bug you're reporting, please include it, too, or make a pull request - this will make the life of the maintainers easier and a bug faster to be fixed. | ||
|
|
||
| <a id="features"></a> | ||
| ## Feature requests | ||
|
|
||
| Feature requests are welcome. But take a moment to find out whether your idea fits with the scope and aims of the project. It's up to *you* to make a strong case to convince the project's developers of the merits of this feature. Please provide as much detail and context as possible and don't forget: | ||
|
|
||
| * Please search for existing feature requests first to see if something similar already exists. | ||
| * Include a clear and specific use-case. We love new ideas, but we do not add features without a reason. | ||
| * Consider whether or not your feature would be better as a function or implemented in a separate project. | ||
|
|
||
| ## Pull requests | ||
|
|
||
| Good pull requests - patches, improvements, new features - are a fantastic help. They should remain focused in scope and avoid containing unrelated commits. You can start by adding a feature request to get feedback and see how your idea is received. | ||
|
|
||
| **Please ask first** before embarking on any significant pull request (e.g. implementing features, refactoring code, porting to a different language), otherwise you risk spending a lot of time working on something that the project's developers might not want to merge into the project. | ||
|
|
||
| Please adhere to the coding conventions used throughout a project (indentation, accurate comments, etc.) and any other requirements (such as test coverage). | ||
|
|
||
| Follow this process if you'd like your work considered for inclusion in the project: | ||
|
|
||
| 1. [Fork](http://help.github.com/fork-a-repo/) the project, clone your fork, and configure the remotes: | ||
|
|
||
| ```bash | ||
| # Clone your fork of the repo into the current directory | ||
| git clone https://github.com/<your-username>/<repo-name> | ||
| # Navigate to the newly cloned directory | ||
| cd <repo-name> | ||
| # Assign the original repo to a remote called "upstream" | ||
| git remote add upstream https://github.com/<upstream-owner>/<repo-name> | ||
| ``` | ||
|
|
||
| 2. If you cloned a while ago, get the latest changes from upstream: | ||
|
|
||
| ```bash | ||
| git checkout <dev-branch> | ||
| git pull upstream <dev-branch> | ||
| ``` | ||
|
|
||
| 3. Create a new topic branch (off the main project development branch) to contain your feature, change, or fix: | ||
|
|
||
| ```bash | ||
| git checkout -b <topic-branch-name> | ||
| ``` | ||
|
|
||
| 4. Commit your changes in logical chunks. Please adhere to these [git commit message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) or your code is unlikely be merged into the main project. Use Git's [interactive rebase](https://help.github.com/articles/interactive-rebase) feature to tidy up your commits before making them public. | ||
|
|
||
| 5. Locally merge (or rebase) the upstream development branch into your topic branch: | ||
|
|
||
| ```bash | ||
| git pull [--rebase] upstream <dev-branch> | ||
| ``` | ||
|
|
||
| 6. Push your topic branch up to your fork: | ||
|
|
||
| ```bash | ||
| git push origin <topic-branch-name> | ||
| ``` | ||
|
|
||
| 7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/) with a clear title and description. | ||
|
|
||
| **IMPORTANT**: By submitting a patch, you agree to allow the project owner to | ||
| license your work under the same license as that used by the project. | ||
|
|
||
| ### Coding Standards | ||
|
|
||
| * Always use spaces, never tabs | ||
| * End lines in semi-colons. | ||
|
|
||
| ## Developing | ||
|
|
||
| If you want to take an issue, just add a small comment saying you are having a go at something, so we don't get duplication. | ||
|
|
||
| [markdown]: https://help.github.com/articles/github-flavored-markdown |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| a.external.no-img, a.external.icon { | ||
| a.external.no-image, a.external.icon { | ||
| background: url(../images/link.png) right center no-repeat; | ||
| padding-right: 12px; | ||
| } | ||
| a.mailto.no-img, a.mailto.icon { | ||
| a.mailto.no-image, a.mailto.icon { | ||
| background: url(../images/mail.png) right center no-repeat; | ||
| padding-right: 12px; | ||
| } | ||
|
|
||
| /* Hide the extra spans when printing. */ | ||
| /* Hide link or mailto icons when printing. */ | ||
| @media print { | ||
| a.extternal, a.mailto { | ||
| display: none; | ||
| a.external, a.mailto { | ||
| background-image: none; | ||
| padding: 0; | ||
| } | ||
| } |
Oops, something went wrong.