Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARHTML-220 Fix FP S5148: Only raise an issue if rel="opener" is explicitly set #337

Merged
merged 1 commit into from
Nov 22, 2024
Merged

SONARHTML-220 Fix FP S5148: Only raise an issue if rel="opener" is explicitly set #337

merged 1 commit into from
Nov 22, 2024

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource commented Nov 22, 2024 •
edited by jira bot
Loading

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

vdiez
vdiez approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit c65bf83 into master Nov 22, 2024
10 of 11 checks passed
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource deleted the SONARHTML-220 branch November 22, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdiez vdiez vdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yassin-kammoun-sonarsource @vdiez