SONARJAVA-4552 Deprecate rule S6374

* Apply deprecation from rspec * Update ruling tests results because the rule is deprecated and removed from default quality profile
SonarSource · Aug 8, 2023 · b6ce292 · b6ce292
1 parent c9e177c
commit b6ce292
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/its/ruling/src/test/java/org/sonar/java/it/AutoScanTest.java b/its/ruling/src/test/java/org/sonar/java/it/AutoScanTest.java
@@ -180,15 +180,15 @@ public void javaCheckTestSources() throws Exception {
     assertThat(newTotal).isEqualTo(knownTotal);
     assertThat(rulesCausingFPs).hasSize(5);
     assertThat(rulesNotReporting).hasSize(7);
-    assertThat(rulesSilenced).hasSize(69);
+    assertThat(rulesSilenced).hasSize(68);
 
     /**
      * 4. Check total number of differences (FPs + FNs)
      *
      * No differences would mean that we find the same issues with and without the bytecode and libraries
      */
     String differences = Files.readString(pathFor(TARGET_ACTUAL + PROJECT_KEY + "-no-binaries_differences"));
-    assertThat(differences).isEqualTo("Issues differences: 3265");
+    assertThat(differences).isEqualTo("Issues differences: 3253");
   }
 
   private static Path pathFor(String path) {

diff --git a/its/ruling/src/test/resources/autoscan/autoscan-diff-by-rules.json b/its/ruling/src/test/resources/autoscan/autoscan-diff-by-rules.json
@@ -2801,12 +2801,6 @@
     "falseNegatives": 15,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S6374",
-    "hasTruePositives": false,
-    "falseNegatives": 12,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S6376",
     "hasTruePositives": false,

diff --git a/java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S6374.html b/java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S6374.html
@@ -1,3 +1,4 @@
+<p>This rule is deprecated; use {rule:java:S2755} instead.</p>
 <h2>Why is this an issue?</h2>
 <p>By default XML processors attempt to load all XML schemas and DTD (their locations are defined with <code>xsi:schemaLocation</code> attributes and
 <code>DOCTYPE</code> declarations), potentially from an external storage such as file system or network, which may lead, if no restrictions are put in

diff --git a/java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S6374.json b/java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S6374.json
@@ -7,7 +7,7 @@
     },
     "attribute": "CONVENTIONAL"
   },
-  "status": "ready",
+  "status": "deprecated",
   "remediation": {
     "func": "Constant\/Issue",
     "constantCost": "15min"